Skip to content

fix: Potential fix for code scanning alert no. 84: Insecure randomne…#76

Merged
Dargon789 merged 0 commit intomasterfrom
alert-fix-75
Oct 16, 2025
Merged

fix: Potential fix for code scanning alert no. 84: Insecure randomne…#76
Dargon789 merged 0 commit intomasterfrom
alert-fix-75

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Oct 16, 2025

…ss #73 (#75)

  • Bump the npm_and_yarn group across 3 directories with 1 update

Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/dapp-client directory: happy-dom.
Bumps the npm_and_yarn group with 1 update in the /packages/wallet/wdk directory: happy-dom.

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0

Updates happy-dom from 17.6.3 to 20.0.0


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn
  • dependency-name: happy-dom dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn ...

Bumps the npm_and_yarn group with 1 update in the / directory: happy-dom.

Updates happy-dom from 20.0.0 to 20.0.2


updated-dependencies:

  • dependency-name: happy-dom dependency-version: 20.0.2 dependency-type: direct:development dependency-group: npm_and_yarn ...

Add a security policy document outlining supported versions and vulnerability reporting.

  • Update SECURITY.md

  • Update SECURITY.md


  • Update SECURITY.md

Summary by Sourcery

Address a code scanning alert by updating the happy-dom dependency to v20.0.2 across wallet packages and introduce a SECURITY.md for security policy.

Bug Fixes:

  • Upgrade happy-dom from v17.2.2 to v20.0.2 in the wallet dapp-client and wdk packages to address insecure randomness scanner alerts

Documentation:

  • Add SECURITY.md defining supported versions and vulnerability reporting guidelines

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Oct 16, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
sequence.js Ready Ready Preview Oct 16, 2025 10:19pm

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 16, 2025

Reviewer's Guide

This PR updates the development dependency happy-dom to its latest patch release across the wallet packages, regenerates the lockfile accordingly, and adds a SECURITY.md document outlining supported versions and vulnerability reporting.

File-Level Changes

Change Details Files
Upgrade happy-dom versions
  • Bump happy-dom from ^17.2.2 to ^20.0.2 in dapp-client
  • Bump happy-dom from ^17.2.2 to ^20.0.2 in wdk
packages/wallet/dapp-client/package.json
packages/wallet/wdk/package.json
Regenerate lockfile
  • Update pnpm-lock.yaml to reflect new dependency versions
pnpm-lock.yaml
Add security policy
  • Create SECURITY.md with supported versions matrix and reporting instructions
SECURITY.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Oct 16, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the project's security posture by updating a key dependency, happy-dom, to its latest stable version. This update is intended to resolve a reported code scanning alert concerning insecure randomness. Additionally, a comprehensive security policy document has been introduced to guide vulnerability reporting and supported versions.

Highlights

  • Dependency Update: The happy-dom package has been updated from version 17.6.3 to 20.0.2 across multiple package.json files and the pnpm-lock.yaml.
  • Security Policy: A new SECURITY.md file has been added to establish a security policy, outlining supported versions and vulnerability reporting procedures.
  • Code Scanning Alert Fix: This pull request aims to address a potential code scanning alert (no. 84) related to insecure randomness, likely resolved by the dependency update.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • After upgrading happy-dom from 17.x to 20.x, verify that all existing tests and mocks still work with any changed APIs or behaviours introduced in the major release.
  • Make sure the pnpm lockfile is fully regenerated and committed for all workspaces so dependency graphs remain consistent after the bump.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- After upgrading happy-dom from 17.x to 20.x, verify that all existing tests and mocks still work with any changed APIs or behaviours introduced in the major release.
- Make sure the pnpm lockfile is fully regenerated and committed for all workspaces so dependency graphs remain consistent after the bump.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a security vulnerability by upgrading the happy-dom dependency, which is a positive step for the project's security. Additionally, the introduction of a SECURITY.md file is a great initiative to formalize the security policy. My review includes a suggestion to improve the new security policy file by removing placeholder text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

# Entity relationship diagram for wagmi-project config and chains/connectors **[Socket for GitHub](https://socket.dev?utm_medium=gh).

1 participant