Conversation
* Bump next from 15.5.7 to 15.5.9 (0xsequence#944) Bumps [next](https://github.com/vercel/next.js) from 15.5.7 to 15.5.9. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.7...v15.5.9) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Pin foundry to v1.5.0 instead of nightly (0xsequence#947) * Include repo and extras in syncpack config to ensure deps are synced (0xsequence#945) * Include repo and extras in syncpack config to ensure deps are synced across all * Updating support deps * Updating deps * Updating pnpm lock * Fixing type errors within wdk tests * Short circuit 404s (0xsequence#949) * skip witness on signers that don't support it * add passkey to test * 3.0.0-beta.6 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: Corban Riley <corbanbrook@gmail.com> Co-authored-by: Agusx1211 <agusgit@pm.me>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
CI: Delete obsolete .circleci/config.yml to fully remove CircleCI configuration from the project. Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a Solidity files cache artifact for signals implicit mode and removes the CircleCI pipeline configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's build and continuous integration processes. It removes an outdated CircleCI configuration, signaling a shift in CI strategy, and introduces a Solidity compiler cache file. The addition of the cache file is intended to optimize compilation times and manage dependencies more efficiently for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request removes an obsolete CircleCI configuration and adds a Solidity compiler cache file. While removing the old CI configuration is a good cleanup, adding the cache file to the repository is not recommended. Cache files are auto-generated and can lead to merge conflicts and repository bloat. I've suggested adding this file to .gitignore.
I am having trouble creating individual review comments. Click here to see my feedback.
lib/signals-implicit-mode/cache/solidity-files-cache.json (1)
Committing cache files like solidity-files-cache.json is generally discouraged. These files are generated by build tools (like Foundry or Hardhat) and can cause several issues:
- Merge Conflicts: They are a common source of merge conflicts when multiple developers are working on the project.
- Repository Bloat: They can significantly increase the size of the repository over time.
- Noise: They add unnecessary noise to commits and pull requests, making it harder to review meaningful code changes.
It's recommended to add this file, or the entire cache/ directory, to your .gitignore file to prevent it from being tracked by version control.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider whether
lib/signals-implicit-mode/cache/solidity-files-cache.jsonis a generated/compiler cache artifact that should be gitignored rather than committed, to avoid churn and environment-specific noise in version control. - With the removal of
.circleci/config.yml, ensure that any remaining project references or badges pointing to CircleCI are cleaned up and that all required CI checks have been fully migrated to the current system.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider whether `lib/signals-implicit-mode/cache/solidity-files-cache.json` is a generated/compiler cache artifact that should be gitignored rather than committed, to avoid churn and environment-specific noise in version control.
- With the removal of `.circleci/config.yml`, ensure that any remaining project references or badges pointing to CircleCI are cleaned up and that all required CI checks have been fully migrated to the current system.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary by Sourcery
Add Solidity cache metadata file and remove legacy CircleCI configuration.
CI:
Chores: