Skip to content

0xsequence/sequence.js/master#269

Closed
Dargon789 wants to merge 12 commits intomasterfrom
0xsequence/sequence.js/master
Closed

0xsequence/sequence.js/master#269
Dargon789 wants to merge 12 commits intomasterfrom
0xsequence/sequence.js/master

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Feb 3, 2026

Summary by Sourcery

Add Solidity cache metadata file and remove legacy CircleCI configuration.

CI:

  • Remove obsolete CircleCI pipeline configuration.

Chores:

  • Add Solidity compiler cache file for implicit-mode signals package.

Dargon789 and others added 11 commits December 22, 2025 22:00
* Bump next from 15.5.7 to 15.5.9 (0xsequence#944)

Bumps [next](https://github.com/vercel/next.js) from 15.5.7 to 15.5.9.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.5.7...v15.5.9)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.5.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Pin foundry to v1.5.0 instead of nightly (0xsequence#947)

* Include repo and extras in syncpack config to ensure deps are synced (0xsequence#945)

* Include repo and extras in syncpack config to ensure deps are synced across all

* Updating support deps

* Updating deps

* Updating pnpm lock

* Fixing type errors within wdk tests

* Short circuit 404s (0xsequence#949)

* skip witness on signers that don't support it

* add passkey to test

* 3.0.0-beta.6

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylan Pince <taylanpince@gmail.com>
Co-authored-by: Corban Riley <corbanbrook@gmail.com>
Co-authored-by: Agusx1211 <agusgit@pm.me>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
CI:

Delete obsolete .circleci/config.yml to fully remove CircleCI configuration from the project.
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Feb 3, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel

This comment was marked as resolved.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 3, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a Solidity files cache artifact for signals implicit mode and removes the CircleCI pipeline configuration.

File-Level Changes

Change Details Files
Introduce a Solidity files cache artifact for signals implicit mode.
  • Add a new JSON cache file to store metadata about Solidity sources for implicit-mode signal handling
  • Persist compiler- or build-related information to speed up or stabilize subsequent builds or tooling runs
lib/signals-implicit-mode/cache/solidity-files-cache.json
Remove CircleCI CI/CD configuration from the repository.
  • Delete the CircleCI pipeline configuration file
  • Effectively disable CircleCI-based builds and checks for this project
.circleci/config.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's build and continuous integration processes. It removes an outdated CircleCI configuration, signaling a shift in CI strategy, and introduces a Solidity compiler cache file. The addition of the cache file is intended to optimize compilation times and manage dependencies more efficiently for the implicit-mode signals package.

Highlights

  • CI Configuration Removal: The legacy CircleCI pipeline configuration file (.circleci/config.yml) has been completely removed, indicating a deprecation of this specific CI setup.
  • Solidity Compiler Cache Addition: A new Solidity compiler cache metadata file (lib/signals-implicit-mode/cache/solidity-files-cache.json) has been added. This file contains detailed information about compiled Solidity contracts, their dependencies, and build artifacts for the implicit-mode signals package, likely to optimize build times.
Changelog
  • .circleci/config.yml
    • Removed the entire legacy CircleCI pipeline configuration file.
  • lib/signals-implicit-mode/cache/solidity-files-cache.json
    • Added a new Solidity compiler cache file, which includes metadata for various Solidity source files, their imports, version requirements, and compiled artifacts for the implicit-mode signals package.
Activity
  • No human activity (comments, reviews, or progress updates) has been recorded for this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Feb 3, 2026 9:45pm
sequence-js-web Ready Ready Preview, Comment Feb 3, 2026 9:45pm

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an obsolete CircleCI configuration and adds a Solidity compiler cache file. While removing the old CI configuration is a good cleanup, adding the cache file to the repository is not recommended. Cache files are auto-generated and can lead to merge conflicts and repository bloat. I've suggested adding this file to .gitignore.

I am having trouble creating individual review comments. Click here to see my feedback.

lib/signals-implicit-mode/cache/solidity-files-cache.json (1)

high

Committing cache files like solidity-files-cache.json is generally discouraged. These files are generated by build tools (like Foundry or Hardhat) and can cause several issues:

  • Merge Conflicts: They are a common source of merge conflicts when multiple developers are working on the project.
  • Repository Bloat: They can significantly increase the size of the repository over time.
  • Noise: They add unnecessary noise to commits and pull requests, making it harder to review meaningful code changes.

It's recommended to add this file, or the entire cache/ directory, to your .gitignore file to prevent it from being tracked by version control.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether lib/signals-implicit-mode/cache/solidity-files-cache.json is a generated/compiler cache artifact that should be gitignored rather than committed, to avoid churn and environment-specific noise in version control.
  • With the removal of .circleci/config.yml, ensure that any remaining project references or badges pointing to CircleCI are cleaned up and that all required CI checks have been fully migrated to the current system.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider whether `lib/signals-implicit-mode/cache/solidity-files-cache.json` is a generated/compiler cache artifact that should be gitignored rather than committed, to avoid churn and environment-specific noise in version control.
- With the removal of `.circleci/config.yml`, ensure that any remaining project references or badges pointing to CircleCI are cleaned up and that all required CI checks have been fully migrated to the current system.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@snyk-io
Copy link

snyk-io bot commented Feb 3, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@Dargon789 Dargon789 closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant