Skip to content

Delete lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs dir…#202

Merged
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1
Jan 10, 2026
Merged

Delete lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs dir…#202
Dargon789 merged 1 commit intomasterfrom
Dargon789-patch-1

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jan 10, 2026

…ectory

erc2470-libs directory non forge std remove and clean

Summary by Sourcery

Enhancements:

  • Clean up unused erc2470-libs contracts, scripts, and configs, including the embedded forge-std library, to reduce duplication and repository bloat.

…ectory

erc2470-libs directory non forge std remove and clean  

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Jan 10, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fully removes the vendored erc2470-libs subtree (including its nested forge-std copy, configs, scripts, and tests) from lib/signals-implicit-mode/lib/sequence-v3/lib, cleaning up unused/non-standard dependencies and project metadata.

File-Level Changes

Change Details Files
Remove the vendored erc2470-libs library subtree and its nested forge-std copy from the sequence-v3 dependencies.
  • Delete the top-level erc2470-libs project metadata and tooling files such as .gitattributes, .gitmodules, .githooks, CI workflow, lint config, README, and foundry.toml
  • Delete the nested forge-std library subtree under erc2470-libs/lib/forge-std, including its configs, licenses, source contracts, mocks, and tests
  • Delete the project-specific Solidity scripts and interfaces under erc2470-libs/script and erc2470-libs/src related to the singleton factory and mock deployer
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/.gitattributes
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/.githooks/pre-commit
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/.github/workflows/test.yml
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/.gitmodules
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/.solhint.json
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/README.md
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/foundry.toml
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/lib/forge-std/*
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/script/MockERC20Deployer.s.sol
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/script/SingletonDeployer.s.sol
lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs/src/ISingletonFactory.sol

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Jan 10, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Repository owner deleted a comment from vercel bot Jan 10, 2026
@vercel
Copy link

vercel bot commented Jan 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Jan 10, 2026 9:00am
sequence-js-web Error Error Jan 10, 2026 9:00am

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a comprehensive cleanup by eliminating the 'erc2470-libs' directory. This action streamlines the project structure by removing a component that is no longer needed, including its internal dependencies, build configurations, and development tooling. The primary goal is to simplify the codebase and remove obsolete elements.

Highlights

  • Directory Removal: The entire 'lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs' directory has been removed, along with all its contents.
  • Dependency Cleanup: This removal includes the 'forge-std' library, which was previously located within the 'erc2470-libs' directory, indicating a significant dependency cleanup.
  • Associated Files Deleted: All configuration files, development scripts, and documentation specific to 'erc2470-libs' (e.g., .gitattributes, .githooks, .github/workflows, .solhint.json, README.md, foundry.toml) have been deleted.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a cleanup by deleting the lib/signals-implicit-mode/lib/sequence-v3/lib/erc2470-libs directory. This is a beneficial change as it removes a large number of unused files, including what appears to be a vendored forge-std library, thereby reducing repository bloat and improving overall maintainability. The changes are consistent with the goal of cleaning up the codebase. I find no issues with this removal.

@Dargon789 Dargon789 merged commit 75ae648 into master Jan 10, 2026
16 of 21 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch January 10, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant