forked from 0xsequence/sequence.js
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Reviewer's Guide
Adds explicit session configuration utilities and exports to the dapp-client, extends login methods to support EOA, adjusts Apple OAuth authcode flow to omit scope, and bumps multiple package versions and changelogs for 3.0.0-beta.10 with associated changesets.
Sequence diagram for Apple authcode OAuth URL generation without scope
sequenceDiagram
actor User
participant DappClient
participant AuthCodeHandler
participant OAuthProvider
User->>DappClient: initiateLogin(method apple)
DappClient->>AuthCodeHandler: buildAuthUrl(signupKind apple)
AuthCodeHandler->>AuthCodeHandler: generateState()
AuthCodeHandler->>AuthCodeHandler: buildSearchParams(client_id, redirect_uri, response_type, state)
AuthCodeHandler-->>DappClient: oauthUrlWithoutScope
DappClient-->>User: redirectTo(oauthUrlWithoutScope)
User->>OAuthProvider: open oauthUrlWithoutScope
OAuthProvider-->>User: Apple consent and login flow
Class diagram for explicit session configuration utilities in dapp-client
classDiagram
class SessionDuration {
+number days
+number hours
+number minutes
}
class NativeTokenSpending {
+bigint valueLimit
+Address.Address[] allowedRecipients
}
class ExplicitSessionParams {
+number chainId
+SessionDuration expiresIn
+Permission.Permission[] permissions
+NativeTokenSpending nativeTokenSpending
}
class ExplicitSessionConfig {
+number chainId
+bigint valueLimit
+bigint deadline
+Permission.Permission[] permissions
}
class DappClientUtils {
+createExplicitSessionConfig(params ExplicitSessionParams) ExplicitSessionConfig
}
class Permission {
}
class Address {
}
ExplicitSessionParams --> SessionDuration : uses
ExplicitSessionParams --> NativeTokenSpending : optional
ExplicitSessionParams --> Permission : uses
NativeTokenSpending --> Address : allowedRecipients
ExplicitSessionConfig --> Permission : uses
DappClientUtils ..> ExplicitSessionParams : input
DappClientUtils ..> ExplicitSessionConfig : output
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Introduce utilities and exports for constructing explicit session configs in the dapp-client utils and main entrypoint. |
|
packages/wallet/dapp-client/src/utils/index.tspackages/wallet/dapp-client/src/index.ts |
| Extend authentication and login surface to support EOA and refine Apple OAuth behavior. |
|
packages/wallet/dapp-client/src/types/index.tspackages/wallet/wdk/src/sequence/handlers/authcode.tspackages/wallet/wdk/test/authcode.test.ts |
| Release 3.0.0-beta.10 across packages, documenting and configuring patch releases for dapp-client, Apple auth fixes, and dependency bumps. |
|
packages/wallet/wdk/CHANGELOG.mdpackages/wallet/dapp-client/CHANGELOG.mdpackages/wallet/core/CHANGELOG.mdpackages/services/relayer/CHANGELOG.mdpackages/services/api/CHANGELOG.mdpackages/services/builder/CHANGELOG.mdpackages/services/guard/CHANGELOG.mdpackages/services/identity-instrument/CHANGELOG.mdpackages/services/indexer/CHANGELOG.mdpackages/services/marketplace/CHANGELOG.mdpackages/services/metadata/CHANGELOG.mdpackages/services/userdata/CHANGELOG.mdpackages/utils/abi/CHANGELOG.mdpackages/wallet/primitives/CHANGELOG.mdpackages/services/api/package.jsonpackages/services/builder/package.jsonpackages/services/guard/package.jsonpackages/services/identity-instrument/package.jsonpackages/services/indexer/package.jsonpackages/services/marketplace/package.jsonpackages/services/metadata/package.jsonpackages/services/relayer/package.jsonpackages/services/userdata/package.jsonpackages/utils/abi/package.jsonpackages/wallet/core/package.jsonpackages/wallet/dapp-client/package.jsonpackages/wallet/primitives/package.jsonpackages/wallet/wdk/package.json.changeset/crisp-zoos-retire.md.changeset/new-turkeys-double.md.changeset/nice-tips-slide.md.changeset/tiny-files-chew.md |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Originally posted by @sourcery-ai[bot] in #237 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Projects
Status
Todo