Skip to content

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Dec 15, 2025

What changed? Why?

Notes to reviewers

How has it been tested?

Summary by Sourcery

CI:

  • Clean up the cli-minikit workflow name and CLI invocation to consistently target the minikit flow.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Resolves a merge conflict in the cli-minikit GitHub Actions workflow by standardizing the workflow name and the CLI invocation used to generate a minikit test project, while leaving the install/build steps unchanged.

Flow diagram for updated cli-minikit GitHub Actions workflow

flowchart TD
  A[GitHub pull_request event on main] --> B[Workflow cli_build_install_minikit]
  B --> C[Job cli-minikit runs on ubuntu-latest]
  C --> D[Checkout repository actions_checkout]
  D --> E[Setup Node.js actions_setup-node]
  E --> F[Install root dependencies
npm install]
  F --> G[Create test project directory
mkdir test-project
cd test-project]
  G --> H[Generate minikit test project
create-onchain cli.js --mini
with scripted stdin]
  H --> I[Install test project dependencies
npm install in test-project/my-onchainkit-app]
  I --> J[Build test project
npm run build]
  J --> K[Job success / failure reported back to pull_request]
Loading

File-Level Changes

Change Details Files
Resolve merge conflict markers and standardize workflow metadata/name.
  • Remove leftover Git merge conflict markers from the workflow file.
  • Set the workflow name to a single, consistent value for the minikit build and install job.
.github/workflows/cli-minikit.yml
Unify the test-project generation step to always run the mini-kit CLI flow.
  • Keep the mini-kit specific CLI invocation that passes the --mini flag and interactive input sequence.
  • Remove the alternative, non-mini invocation path that lacked the --mini flag.
.github/workflows/cli-minikit.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@snyk-io
Copy link

snyk-io bot commented Dec 15, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Repository owner deleted a comment from vercel bot Dec 15, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The updated workflow name and CLI invocation semantics have changed from the previous onchainkit variant; if this is intended to supersede that behavior, consider aligning or clearly differentiating naming/flags so it’s obvious which workflow covers which use case.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The updated workflow name and CLI invocation semantics have changed from the previous onchainkit variant; if this is intended to supersede that behavior, consider aligning or clearly differentiating naming/flags so it’s obvious which workflow covers which use case.

## Individual Comments

### Comment 1
<location> `.github/workflows/cli-minikit.yml:54` </location>
<code_context>
           cd test-project
-<<<<<<<< HEAD:.github/workflows/cli-minikit.yml
+          
           (sleep 1; echo ""; sleep 1; echo ""; sleep 1; echo -e "\033[D\n"; sleep 1; echo -e "\033[D\n") | ../packages/create-onchain/dist/esm/cli.js --mini
-========
-          (sleep 1; echo ""; sleep 1; echo ""; sleep 1; echo ""; sleep 1; echo -e "\033[D\n") | ../packages/create-onchain/dist/esm/cli.js
</code_context>

<issue_to_address>
**suggestion (testing):** The CLI interaction script using sleeps and escape codes is fairly brittle and might be prone to flakiness.

Using chained `sleep`/`echo` with cursor escape codes ties this step to specific timing and TTY behavior on the GitHub runner, which is likely to be flaky. Prefer a more deterministic input mechanism (e.g., here-doc, `printf`, or CLI flags/env vars if available) so the interaction is stable and easier to maintain.

Suggested implementation:

```
          cd test-project

          # Provide deterministic stdin to the CLI instead of relying on timing/cursor escape sequences.
          # Adjust the number/content of newlines if the CLI’s prompts change.
          printf '\n\n\n\n' | ../packages/create-onchain/dist/esm/cli.js --mini

```

If the CLI expects specific answers (not just “enter to accept default”), replace the `printf '\n\n\n\n'` with the exact answers, one per line, for example:
`printf 'my-app-name\noption-1\n\nfinal-answer\n' | ...`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit 7333229 into main Dec 15, 2025
12 of 20 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-2 branch December 15, 2025 06:02
@Dargon789 Dargon789 linked an issue Dec 15, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@coinbase/onchainki wagmi

2 participants