Skip to content

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Dec 15, 2025

What changed? Why?

Notes to reviewers

How has it been tested?

Summary by Sourcery

Clean up the onchainkit CLI verification workflow by resolving merge artifacts and aligning the test project generation step with the standard onchainkit CLI usage.

Enhancements:

  • Rename the workflow to target onchainkit explicitly and remove leftover merge conflict markers.
  • Update the test project generation command to use the default onchainkit CLI flow instead of the mini variant.

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Resolve leftover merge conflict markers in the cli-verify-onchainkit-template GitHub Actions workflow so it correctly builds and installs the onchainkit template instead of the minikit variant, and standardize the non-interactive CLI invocation script.

File-Level Changes

Change Details Files
Fix workflow name and remove merge-conflict remnants so the workflow clearly targets onchainkit instead of minikit.
  • Set the workflow name to 'cli: build & install onchainkit'.
  • Removed stray merge-conflict markers and alternative minikit-specific name lines.
.github/workflows/cli-verify-onchainkit-template.yml
Normalize the non-interactive CLI invocation used to generate the test project for verification.
  • Removed the minikit-specific CLI invocation with the --mini flag and terminal control characters.
  • Use a simplified scripted input sequence for ../packages/create-onchain/dist/esm/cli.js that matches the onchainkit template use case.
.github/workflows/cli-verify-onchainkit-template.yml
Align test project build step with current expectations.
  • Ensure the test project installs dependencies via npm install.
  • Run npm run build after installation to verify the generated onchainkit app builds successfully.
.github/workflows/cli-verify-onchainkit-template.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Dec 15, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Repository owner deleted a comment from vercel bot Dec 15, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The workflow no longer runs npm run build in the test project; if build verification is still desired for this check, consider adding the build step back or clarifying why it's no longer needed.
  • The updated non-mini create-onchain CLI invocation now uses a different sequence of simulated inputs; if these correspond to specific prompts, it may be helpful to add a brief comment describing which choices are being selected to make future adjustments easier.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The workflow no longer runs `npm run build` in the test project; if build verification is still desired for this check, consider adding the build step back or clarifying why it's no longer needed.
- The updated non-mini `create-onchain` CLI invocation now uses a different sequence of simulated inputs; if these correspond to specific prompts, it may be helpful to add a brief comment describing which choices are being selected to make future adjustments easier.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Repository owner deleted a comment from vercel bot Dec 15, 2025
@Dargon789 Dargon789 merged commit 0dd1cb7 into main Dec 15, 2025
11 of 19 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch December 15, 2025 06:12
@Dargon789 Dargon789 linked an issue Dec 15, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@coinbase/onchainki wagmi

2 participants