-
Notifications
You must be signed in to change notification settings - Fork 0
Update cli-verify-onchainkit-template.yml #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideResolve leftover merge conflict markers in the cli-verify-onchainkit-template GitHub Actions workflow so it correctly builds and installs the onchainkit template instead of the minikit variant, and standardize the non-interactive CLI invocation script. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The workflow no longer runs
npm run buildin the test project; if build verification is still desired for this check, consider adding the build step back or clarifying why it's no longer needed. - The updated non-mini
create-onchainCLI invocation now uses a different sequence of simulated inputs; if these correspond to specific prompts, it may be helpful to add a brief comment describing which choices are being selected to make future adjustments easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The workflow no longer runs `npm run build` in the test project; if build verification is still desired for this check, consider adding the build step back or clarifying why it's no longer needed.
- The updated non-mini `create-onchain` CLI invocation now uses a different sequence of simulated inputs; if these correspond to specific prompts, it may be helpful to add a brief comment describing which choices are being selected to make future adjustments easier.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
1771960 to
b01f393
Compare
What changed? Why?
Notes to reviewers
How has it been tested?
Summary by Sourcery
Clean up the onchainkit CLI verification workflow by resolving merge artifacts and aligning the test project generation step with the standard onchainkit CLI usage.
Enhancements: