[Snyk] Fix for 7 vulnerabilities - #86
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-H3-15010914 - https://snyk.io/vuln/SNYK-JS-NEXT-10259370 - https://snyk.io/vuln/SNYK-JS-NEXT-12265451 - https://snyk.io/vuln/SNYK-JS-NEXT-12299318 - https://snyk.io/vuln/SNYK-JS-NEXT-12301496 - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
|
Deployment failed with the following error: Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit |
|
| Status | Scanner | Total (0) | ||||
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, addresses critical security vulnerabilities within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, proposes upgrading next and wagmi to fix security vulnerabilities. However, both upgrades are major version bumps (next 14->15, wagmi 2->3) and introduce significant breaking changes that will likely break the application. The wagmi upgrade conflicts with peer dependencies in other packages in this monorepo and a yarn resolution in the root package.json. The next upgrade to v15 requires React 19, while the project uses React 18. Furthermore, the PR description notes that yarn.lock has not been updated, which is a critical step. Due to these critical issues, this PR cannot be merged as-is and requires a significant migration effort across the repository.
| "dedent": "^1.5.3", | ||
| "lucide-react": "^0.394.0", | ||
| "next": "14.2.29", | ||
| "next": "15.5.10", |
There was a problem hiding this comment.
Upgrading next from version 14 to 15 is a major version bump that introduces significant breaking changes. Next.js 15 uses React 19, but this project is currently configured with "react": "^18". This version mismatch will cause build failures or runtime errors. A full migration following the Next.js upgrade guide is required before this change can be safely merged.
| "tailwind-merge": "^2.3.0", | ||
| "viem": "^2.45.0", | ||
| "wagmi": "^2.15.5", | ||
| "wagmi": "^3.0.0", |
There was a problem hiding this comment.
Upgrading wagmi from version 2 to 3 is a major version bump with breaking changes. This upgrade will cause dependency conflicts within the monorepo:
- The
@account-kit/coreand@account-kit/reactpackages have a peer dependency onwagmi: "^2.15.5". - The root
package.jsonenforceswagmi: "2.15.5"via yarn resolutions.
To resolve this, wagmi must be upgraded across all dependent packages in the monorepo, and the code must be adapted to the new breaking changes.
370f691 to
fe3be8b
Compare
Snyk has created this PR to fix 7 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
examples/ui-demo/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-H3-15010914
SNYK-JS-NEXT-10259370
SNYK-JS-NEXT-12265451
SNYK-JS-NEXT-12299318
SNYK-JS-NEXT-12301496
SNYK-JS-NEXT-14400636
SNYK-JS-NEXT-15104645
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Server-side Request Forgery (SSRF)
🦉 Deserialization of Untrusted Data
🦉 Allocation of Resources Without Limits or Throttling