[Snyk] Security upgrade wagmi from 2.12.7 to 3.0.0 - #68
Conversation
…updates Bumps the npm_and_yarn group with 2 updates in the / directory: [esbuild](https://github.com/evanw/esbuild) and [next](https://github.com/vercel/next.js). Bumps the npm_and_yarn group with 1 update in the /account-kit/plugingen directory: [esbuild](https://github.com/evanw/esbuild). Bumps the npm_and_yarn group with 1 update in the /doc-gen directory: [esbuild](https://github.com/evanw/esbuild). Bumps the npm_and_yarn group with 1 update in the /examples/ui-demo directory: [next](https://github.com/vercel/next.js). Updates `esbuild` from 0.20.2 to 0.25.0 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md) - [Commits](evanw/esbuild@v0.20.2...v0.25.0) Updates `next` from 14.2.29 to 14.2.30 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.29...v14.2.30) Updates `esbuild` from 0.20.2 to 0.25.5 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md) - [Commits](evanw/esbuild@v0.20.2...v0.25.0) Updates `esbuild` from 0.20.2 to 0.25.5 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2024.md) - [Commits](evanw/esbuild@v0.20.2...v0.25.0) Updates `next` from 14.2.29 to 14.2.30 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.29...v14.2.30) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.25.0 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: next dependency-version: 14.2.30 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: esbuild dependency-version: 0.25.5 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: esbuild dependency-version: 0.25.5 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: next dependency-version: 14.2.30 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
#41) Bumps the npm_and_yarn group with 1 update in the / directory: [esbuild](https://github.com/evanw/esbuild). Updates `esbuild` from 0.25.5 to 0.25.6 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.25.5...v0.25.6) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.25.6 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…44) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-REXML-12878608 Co-authored-by: snyk-io[bot] <141718529+snyk-io[bot]@users.noreply.github.com>
Bumps the bundler group with 1 update in the /account-kit/rn-signer/example directory: [rexml](https://github.com/ruby/rexml). Updates `rexml` from 3.3.9 to 3.4.2 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.3.9...v3.4.2) --- updated-dependencies: - dependency-name: rexml dependency-version: 3.4.2 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…updates (#42) Bumps the npm_and_yarn group with 4 updates in the / directory: [esbuild](https://github.com/evanw/esbuild), [next](https://github.com/vercel/next.js), [sha.js](https://github.com/crypto-browserify/sha.js) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Bumps the npm_and_yarn group with 1 update in the /examples/ui-demo directory: [next](https://github.com/vercel/next.js). Updates `esbuild` from 0.25.6 to 0.25.7 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.25.6...v0.25.7) Updates `next` from 14.2.30 to 14.2.32 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.30...v14.2.32) Updates `sha.js` from 2.4.11 to 2.4.12 - [Changelog](https://github.com/browserify/sha.js/blob/master/CHANGELOG.md) - [Commits](browserify/sha.js@v2.4.11...v2.4.12) Updates `vite` from 5.4.19 to 5.4.20 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.20/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.20/packages/vite) Updates `next` from 14.2.30 to 14.2.32 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.2.30...v14.2.32) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.25.7 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: next dependency-version: 14.2.32 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: sha.js dependency-version: 2.4.12 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: vite dependency-version: 5.4.20 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: next dependency-version: 14.2.32 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the bundler group with 1 update in the /examples/react-native-bare-example directory: [rexml](https://github.com/ruby/rexml). Updates `rexml` from 3.4.1 to 3.4.2 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.4.1...v3.4.2) --- updated-dependencies: - dependency-name: rexml dependency-version: 3.4.2 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dates (#46) Bumps the npm_and_yarn group with 2 updates in the / directory: [axios](https://github.com/axios/axios) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). Updates `axios` from 1.9.0 to 1.12.2 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.9.0...v1.12.2) Updates `vite` from 5.4.20 to 5.4.21 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.21/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.21/packages/vite) --- updated-dependencies: - dependency-name: axios dependency-version: 1.12.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: vite dependency-version: 5.4.21 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ensitive information (#48) * Potential fix for code scanning alert no. 11: Clear text storage of sensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Potential fix for code scanning alert no. 15: Use of password hash with insufficient computational effort Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Potential fix for code scanning alert no. 16: Use of password hash with insufficient computational effort Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update account-kit/signer/src/session/manager.ts Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update account-kit/signer/src/session/manager.ts Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…h 1 update Bumps the npm_and_yarn group with 1 update in the / directory: [@react-native-community/cli](https://github.com/react-native-community/cli/tree/HEAD/packages/cli). Bumps the npm_and_yarn group with 1 update in the /account-kit/rn-signer directory: [@react-native-community/cli](https://github.com/react-native-community/cli/tree/HEAD/packages/cli). Bumps the npm_and_yarn group with 1 update in the /account-kit/rn-signer/example directory: [@react-native-community/cli](https://github.com/react-native-community/cli/tree/HEAD/packages/cli). Bumps the npm_and_yarn group with 1 update in the /examples/react-native-bare-example directory: [@react-native-community/cli](https://github.com/react-native-community/cli/tree/HEAD/packages/cli). Updates `@react-native-community/cli` from 15.0.1 to 20.0.0 - [Release notes](https://github.com/react-native-community/cli/releases) - [Changelog](https://github.com/react-native-community/cli/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/react-native-community/cli/commits/v20.0.0/packages/cli) Updates `@react-native-community/cli` from 15.0.1 to 20.0.0 - [Release notes](https://github.com/react-native-community/cli/releases) - [Changelog](https://github.com/react-native-community/cli/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/react-native-community/cli/commits/v20.0.0/packages/cli) Updates `@react-native-community/cli` from 15.0.1 to 20.0.0 - [Release notes](https://github.com/react-native-community/cli/releases) - [Changelog](https://github.com/react-native-community/cli/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/react-native-community/cli/commits/v20.0.0/packages/cli) Updates `@react-native-community/cli` from 15.0.1 to 20.0.0 - [Release notes](https://github.com/react-native-community/cli/releases) - [Changelog](https://github.com/react-native-community/cli/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/react-native-community/cli/commits/v20.0.0/packages/cli) --- updated-dependencies: - dependency-name: "@react-native-community/cli" dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: "@react-native-community/cli" dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: "@react-native-community/cli" dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: "@react-native-community/cli" dependency-version: 20.0.0 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [@react-native-community/cli](https://github.com/react-native-community/cli/tree/HEAD/packages/cli). Updates `@react-native-community/cli` from 15.0.1 to 17.0.1 - [Release notes](https://github.com/react-native-community/cli/releases) - [Changelog](https://github.com/react-native-community/cli/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/react-native-community/cli/commits/v17.0.1/packages/cli) --- updated-dependencies: - dependency-name: "@react-native-community/cli" dependency-version: 17.0.1 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…abilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSYAML-13961110
…abilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSYAML-13961110
…ties (#60) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-EXPRESS-14157151 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-14400636 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-H3-15010914
|
Deployment failed with the following error: Learn More: https://vercel.com/dargon789-forge?upgradeToPro=build-rate-limit |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated security fix initiated by Snyk, aiming to resolve a high-severity HTTP Request Smuggling vulnerability by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
| Status | Scanner | Total (0) | ||||
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
There was a problem hiding this comment.
Code Review
This pull request from Snyk aims to fix a security vulnerability by upgrading wagmi from version 2.12.7 to 3.0.0. However, the upgrade is incomplete and will break the project if merged as is. This is a major version upgrade with breaking changes, and the wagmi dependency needs to be updated across the entire monorepo to ensure compatibility and resolve dependency conflicts.
Specifically, the following files also require changes:
- The root
package.jsonneeds itsresolutionsanddevDependenciesforwagmito be updated. account-kit/core/package.jsonneeds itspeerDependencyonwagmiupdated.account-kit/react/package.jsonneeds itspeerDependencyonwagmiupdated.
After updating these dependencies, you will also need to run yarn to update yarn.lock (as noted by Snyk) and then address any breaking changes in the source code resulting from the wagmi v3 upgrade.
| "tailwind-merge": "^2.3.0", | ||
| "viem": "^2.29.2", | ||
| "wagmi": "^2.12.7", | ||
| "wagmi": "^3.0.0", |
There was a problem hiding this comment.
Upgrading wagmi to a new major version (3.0.0) is a breaking change. This update is incomplete as it only targets this package. To prevent breaking the build and ensure consistency, wagmi must be upgraded across the entire monorepo. Failing to update wagmi in other packages (like @account-kit/core, @account-kit/react, and the root package.json) will lead to dependency conflicts and break the application. Please see the general summary for more details on the required changes.
370f691 to
fe3be8b
Compare
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
examples/ui-demo/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-H3-15010914
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.