Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #418 for DeleteAsync #1309

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Fix issue #418 for DeleteAsync #1309

merged 2 commits into from
Sep 21, 2019

Conversation

james-hester
Copy link
Contributor

No description provided.

@mgravell
Copy link
Member

I'm confused because the linked bug reports to be fixed; do you have an example (ideally as a test) that shows this problem happening, and then not happening with the fix?

@james-hester
Copy link
Contributor Author

Sorry for the confusion. The test case in the last commit illustrates the problem. Without the fix, it throws the following exception:

System.Data.DataException: GetAsync<T> only supports an entity with a single [Key] or [ExplicitKey] property. [Key] Count: 1, [ExplicitKey] Count: 1

@NickCraver
Copy link
Member

@mgravell for context: this was fixed in the sync version, but not the async version - I agree let's make them match here, but then we'll need to rewrite all this stuff when time ever allows - it's far from optimal (and maintainable) at the moment but that's because it hasn't been extremely coordinated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants