Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support F# anonymous types #1233

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

support F# anonymous types #1233

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
134244f
add test
enricosada Apr 5, 2019
ab01114
fallback to constructor by sorted names, if exists
enricosada Apr 5, 2019
c8b5ce7
refactor convert ternary conditional to ifs
enricosada Apr 6, 2019
67e5f2f
reorder constructor arguments on stack
enricosada Apr 7, 2019
ff10a67
cleanup
enricosada Apr 8, 2019
1892511
reorder only if there are parameters, same count too
enricosada Apr 8, 2019
8f3b15f
specify comparison
enricosada Apr 8, 2019
02707d3
fix after rebase
enricosada Oct 16, 2019
593e5f0
refactor rename
enricosada Oct 16, 2019
c053dfc
use Array.Sort
enricosada Jan 8, 2020
f6cc092
Merge remote-tracking branch 'origin/main' into pr/1233
May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor convert ternary conditional to ifs
  • Loading branch information
@enricosada
enricosada authored and Enrico Sada committed Jan 8, 2020
commit c8b5ce7b9443e3f85fb7cc398620b1e82469698d
12 changes: 9 additions & 3 deletions Dapper/SqlMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3258,9 +3258,15 @@ private static void GenerateDeserializerFromMap(Type type, IDataReader reader, i
il.Emit(OpCodes.Ldloc, returnValueLocal); // [target]
}

var members = (specializedConstructor != null
? names.Select(n => typeMap.GetConstructorParameter(specializedConstructor, n))
: names.Select(n => typeMap.GetMember(n))).ToList();
List<IMemberMap> members;
if (specializedConstructor != null)
{
members = names.Select(n => typeMap.GetConstructorParameter(specializedConstructor, n)).ToList();
}
else
{
members = names.Select(n => typeMap.GetMember(n)).ToList();
}

// stack is now [target]
bool first = true;
Expand Down