readonly struct

[SergerGood]

added for comparison

[NickCraver]

There's a lot more in this PR, namely it changes all the base levels of the libraries fro net451 to net471 (this is a breaking change...which we wouldn't want). Is it possible that some branches got mixed up here?

[SergerGood]

rollback .net franework target

[NickCraver]

Looking much better! I need to see which version of C# this actually needs (latest has issues with build servers and such) and use that version, e.g. 7.3 is safe. In any case, we should locate that in Directory.Build.props instead of each project. properties in there apply across all projects :)

Pinging @mgravell for breaking change eyes - I'm not 100% on the rules here.

[mgravell]

The change to add in on the public methods is absolutely a breaking change; fine for the non-public, but no-go for the public, until the next time we're doing a hard break.

Context: https://sharplab.io/#v2:EYLgtghgzgLgpgJwDQxASwDYB8ACBmAAgTggBMB7AOwwE8DYEBXAYxgIDFzyCBvIkitTppKbYBAQBuAgF8AsACh8BHACYCAYV6KCulYRwAWAgEEoANQiVMGCAApO3AGZcAlLxkEA9F4IA3CAxGOBgaAAc4Di4CF3IdPWUjUygASUo7ESjnNw9vXwBtEQBdf0Dg0IisgDIYrnjdROMzACU4JztiJyza8nceTx9SoJDwyMca2MUZIA

[mgravell]

bits of this look fine, but to emphasize we can't take things like the change to add in on public methods like:

public static int Execute(this IDbConnection cnn, in CommandDefinition command) => ExecuteImpl(cnn, command);

Do you want to revisit? or should I pick and choose pieces?

[SergerGood]

done, but there are problems with WIP

[mgravell]

Assigning to self; will re-review and get back