Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pyproject.toml with build dependencies #958

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add pyproject.toml with build dependencies #958

wants to merge 2 commits into from

Commits on May 17, 2024

  1. add pyproject.toml with build dependencies 

    Adding this metadata means it is possible to `pip install flash-attn`
without pre-installing the packages imported in setup.py. It is still
possible to follow the existing manual instructions, too, but by not
requiring pre-installation it _also_ makes it easier for someone to
build from the source dist.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
    @dhellmann
    dhellmann committed May 17, 2024
    Configuration menu
    Copy the full SHA
    df984ba View commit details
    Browse the repository at this point in the history

  2. update Makefile step for building sdist to use 'build' 

    The build package provides a front-end to the standard APIs for
generating build artifacts like sdists and wheels from source
code. Using build means the pyproject.toml file is processed, which
means the build dependencies imported by setup.py can be installed
before setup.py itself is processed.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
    @dhellmann
    dhellmann committed May 17, 2024
    Configuration menu
    Copy the full SHA
    52224dc View commit details
    Browse the repository at this point in the history