Dev portal 2/4: first-visit experience splash + "interested" voting#232
Open
dmccoystephenson wants to merge 1 commit into
Open
Dev portal 2/4: first-visit experience splash + "interested" voting#232dmccoystephenson wants to merge 1 commit into
dmccoystephenson wants to merge 1 commit into
Conversation
Adds an ExperienceSplash shown once per visitor on the homepage — "I run a server" (stays put) vs "I build plugins" (goes to /dev) — remembered via a localStorage flag so it never nags a returning visitor; the Dev Portal nav link (added in the prior PR) remains the way to switch anytime. Extends the existing like mechanism (already live for plugins/guides) to issues: `targetType: 'issue'`, keyed by `repo#number`. No new backend concept — the /dev console's item rows get an "Interested" button reusing LikeButton, so which of the ~100 open issues people actually want becomes visible without building a second voting system. Second phase of the dev-portal stack (builds on #231).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #231. Second phase of the dev-portal plan.
ExperienceSplash— shown once per visitor on/: "I run a server" (dismiss, stay on the plugin catalogue) vs "I build plugins" (go to/dev). Remembered via adpc-experience-chosenlocalStorage flag so it never reappears; backdrop/Escape dismiss counts as "I run a server" rather than trapping the visitor. The "Dev Portal" nav link from Dev portal 1/4: mirror open GitHub issues/PRs into a /dev backlog console #231 remains the way to switch anytime after that — deliberately not a permanent redirect on/, since that would fight with the "Home" nav link.issue(keyedrepo#number) — one line inLikeService.ALLOWED_TYPES, no new backend concept. The/devitem list gets an "Interested" column reusing the sameLikeButtonalready used for plugins/guides.Why
This is the "users are a thing now" half of the ask: reuse what already shipped (login + likes) instead of building a parallel voting system, and let the splash be a light touch rather than gating the whole site behind a choice.
Test plan
./mvnw test— 130 tests, 0 failures (1 skip, same asmain)npm run lint— cleannpm test— 84 tests, 0 failuresnpm run build— compiles;/and/devboth renderexperience.test.tsand the existingLikeButton/likeServicetest coverage instead.🤖 Generated with Claude Code