Allow request md files with or without the .md extension #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannyBen
requested changes
Aug 7, 2018
lib/madness/breadcrumbs.rb
Outdated
| @@ -27,7 +27,7 @@ def get_breadcrumbs | |||
| def breadcrumbs_maker(partial_path) | |||
| parent, basename = File.split partial_path | |||
| item = OpenStruct.new({ | |||
| label: basename.to_label, | |||
| label: File.basename(basename, '.md').to_label, | |||
There was a problem hiding this comment.
Maybe this would be better in StringRefinements#to_label?
spec/fixtures/cli/theme-ls
Outdated
| @@ -1,4 +1,3 @@ | |||
| tmp/theme-test: | |||
| public | |||
There was a problem hiding this comment.
Why the change in this file? Seems to also be related to why the CI tests fail?
There was a problem hiding this comment.
Sorry. I don't know why the output of ls -R #{theme_dir} is different on my system. I'm going to recover the previous content and comment that test in local to be able to check the other ones.
There was a problem hiding this comment.
No worries. I will change the test to be more tolerant after we merge this.
DannyBen
approved these changes
Aug 8, 2018
|
Beautiful work. Is it ready to merge as far as you are concerned? |
|
Yes. I think so. |
|
Thanks for the nice PR. This is now released as v0.6.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to solve the issue #65