New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update breadcrumbs href with a trailing slash #175

Merged

DannyBen merged 3 commits into master from add/breadcrumbs-trailing-slash

Apr 10, 2024

Owner

DannyBen commented Apr 10, 2024 •

edited

Loading

This PR adds a trailing slash to all links in the breadcrumbs.
In addition, the following internal changes were done:

The breadcrumbs array returns an array of named structs (Breadcrumb) instead of OpenStruct.
The last breadcrumb will have its href set to nil, instead of having the last: true attribute.
Rationale:
- The last element is never a link
- The last element is the only element that can either be a file or a folder, and all links end with a / - which means the link may be inappropriate anyway.

DannyBen added 3 commits

April 10, 2024 03:51


          - Update breadcrumbs href with a trailing slash

6ecf43d


          - Refactor breadcrumbs data structure

509b23b


          lint

8b3a723

DannyBen merged commit 540020d into master

6 checks passed

DannyBen deleted the add/breadcrumbs-trailing-slash branch

April 10, 2024 04:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet