Skip to content

Conversation

DanielNoord
Copy link
Owner

Closes #54.

@DanielNoord DanielNoord added this to the 0.6.0 milestone May 3, 2022
@DanielNoord DanielNoord added the enhancement New feature or request label May 3, 2022
@github-actions

This comment has been minimized.

@coveralls
Copy link

coveralls commented May 3, 2022

Pull Request Test Coverage Report for Build 2263991134

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2259710941: 0.0%
Covered Lines: 470
Relevant Lines: 470

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented May 3, 2022

Diff from the primer, showing the effect of this PR on open source code:
pylint:

https://github.com/PyCQA/pylint/blob/main/pylint/checkers/__init__.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/__init__.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/__init__.py
@@ -38,7 +38,6 @@
 
 The raw_metrics checker has no number associated since it doesn't emit any
 messages nor reports. XXX not true, emit a 07 report !
-
 """
 
 from __future__ import annotations

https://github.com/PyCQA/pylint/blob/main/pylint/checkers/classes/class_checker.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/classes/class_checker.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/classes/class_checker.py
@@ -257,7 +257,6 @@
        * one of the methods is having variadics, while the other is not
 
        * they have different keyword only parameters.
-
     """
     output_messages = []
     original_parameters = _positional_parameters(original)

https://github.com/PyCQA/pylint/blob/main/pylint/checkers/refactoring/refactoring_checker.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/refactoring/refactoring_checker.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/refactoring/refactoring_checker.py
@@ -1700,7 +1700,6 @@
 
         Args:
             node (nodes.FunctionDef): the function holding the return statements.
-
         """
         # explicit return statements are those with a not None value
         explicit_returns = [
@@ -1785,7 +1784,6 @@
 
         Returns:
             bool: True if the node ends with an explicit statement, False otherwise.
-
         """
         # Recursion base case
         if isinstance(node, nodes.Return):

https://github.com/PyCQA/pylint/blob/main/pylint/checkers/spelling.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/spelling.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/spelling.py
@@ -90,7 +90,6 @@
 
     This filter skips any words the match the expression
     assigned to the class attribute ``_pattern``.
-
     """
 
     _pattern: Pattern[str]

https://github.com/PyCQA/pylint/blob/main/pylint/checkers/utils.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/utils.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/checkers/utils.py
@@ -1003,7 +1003,6 @@
 
     Returns:
         list: the collection of handlers that are handling the exception or None.
-
     """
     context = find_try_except_wrapper_node(node)
     if isinstance(context, nodes.TryExcept):

https://github.com/PyCQA/pylint/blob/main/pylint/epylint.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/epylint.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/epylint.py
@@ -31,7 +31,6 @@
 
    - As this script will be invoked by Emacs within the directory of the file
      we are checking we need to go out of it to avoid these false positives.
-
 
 You may also use py_run to run pylint with desired options and get back (or not)
 its output.

https://github.com/PyCQA/pylint/blob/main/pylint/extensions/_check_docs_utils.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/extensions/_check_docs_utils.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/extensions/_check_docs_utils.py
@@ -107,7 +107,6 @@
     .. note::
 
         Caught exception types are ignored.
-
 
     :param node: The raise node to find exception types for.
 

https://github.com/PyCQA/pylint/blob/main/pylint/extensions/broad_try_clause.py

--- ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/extensions/broad_try_clause.py
+++ ../.pydocstringformatter_primer_tests/PyCQA/pylint/pylint/extensions/broad_try_clause.py
@@ -22,7 +22,6 @@
     According to PEP 8, ``try`` clauses shall contain the absolute minimum
     amount of code. This checker enforces a maximum number of statements within
     ``try`` clauses.
-
     """
 
     # configuration section name

Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, the result in pylint too ! 👌

@DanielNoord DanielNoord merged commit fb2f6cc into main May 3, 2022
@DanielNoord DanielNoord deleted the whiteline branch May 3, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the last line if after whitespace stripping it became empty

3 participants