Skip to content

Comments

chore: fix all phpcs and phpstan issues#81

Merged
Daniel-Marynicz merged 1 commit intoDaniel-Marynicz:mainfrom
mRoca:chore/cs
Jan 20, 2026
Merged

chore: fix all phpcs and phpstan issues#81
Daniel-Marynicz merged 1 commit intoDaniel-Marynicz:mainfrom
mRoca:chore/cs

Conversation

@mRoca
Copy link
Contributor

@mRoca mRoca commented Jan 19, 2026

  • fix all phpcs issues
  • fix all phpstan issues
  • add QA tools in dev dependencies for all developpers
  • set the oldest working version of all packages in composer.json / remove the ones not compatible with the main code
  • upgrade github actions ubuntu image
  • add php 8.4 in tests matrix
  • add the documentation about "how to run tests with the lowest allowed versions" in README.md

I will add Symfony 8 in another PR after this one's merge.

@mRoca mRoca force-pushed the chore/cs branch 2 times, most recently from bf4c90f to c1696c6 Compare January 19, 2026 15:29
@Daniel-Marynicz
Copy link
Owner

@mRoca phpstan requires php 7.4. easiest to fix to is to drop support to php 7.3 and older versions.

@mRoca
Copy link
Contributor Author

mRoca commented Jan 20, 2026

@mRoca phpstan requires php 7.4. easiest to fix to is to drop support to php 7.3 and older versions.

I dropped php 7.2 and 7.3, and use php 8.4 for phpstan and phpcs in CI : https://github.com/Daniel-Marynicz/BehatParallelExtension/compare/c1696c6b7b8038a6cb9dbd93d502474ec38c5190..a338157776ce39b343f42386953ac8faacb59dbd

php >= 7.4 < 8.2 will only be used for phpunit and behat

@Daniel-Marynicz Daniel-Marynicz merged commit 4223203 into Daniel-Marynicz:main Jan 20, 2026
7 checks passed
@mRoca mRoca deleted the chore/cs branch January 20, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants