-
-
Notifications
You must be signed in to change notification settings - Fork 13
Improve static routes UX #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alehaa
wants to merge
8
commits into
DanSheps:main
Choose a base branch
from
alehaa:feature/ux-static-routes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All fields are grouped into fieldsets. They now support translations if translated messages are available.
For static routes, the IP versions must match. For example, an IPv4 route must use an IPv4 next-hop gateway. The StaticRoute model now validates this constraint.
DanSheps
requested changes
Jul 20, 2025
auto-merge was automatically disabled
August 2, 2025 16:18
Head branch was pushed to by a user without write access
9153b18
to
f3c102b
Compare
This reverts commit f77a057, as IP routes indeed may mix IP versions for forwarding.
DanSheps
approved these changes
Aug 10, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates minor enhancements to the user interface of static routes, such as organizing form fields and implementing warnings for routes that have been misconfigured.