fixups for directory by listener#8
Closed
nothingmuch wants to merge 3 commits intoDanGould:directory-by-listenerfrom
Closed
fixups for directory by listener#8nothingmuch wants to merge 3 commits intoDanGould:directory-by-listenerfrom
nothingmuch wants to merge 3 commits intoDanGould:directory-by-listenerfrom
Conversation
ensure that the db: testcontainer::Container variable does not go out of scope while the directory is running. previously the directory task itself was awaited on by init_directory, whereas in the modified code it is instead returned as part of the result due to the different return value of listen_tcp_with_tls_on_free_port. this indirection de-coupled the db variable's lifetime from that of the directory, allowing it to go out of scope earlier than expected.
This was referenced Nov 29, 2024
Owner
|
@spacebear21 incorporated this into payjoin#388 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the problem was that redis was being shut down prematurely, see long commit message of final fixup commit
different fixes are separated into different commits at your discretion:
i didn't bother making 3 pretty since the commit i was ammending seemed quite WIP, this needs some finessing since
dbborrows fromdockerand both must persist, so i just copypasted that boilerplate into all of the tests that call init_directory to make them workthis seems to be working well now, but i never observed the flakiness myself so not sure how much that counts for