Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ttf format #6

Merged
merged 7 commits into from
Feb 14, 2021
Merged

Fix ttf format #6

merged 7 commits into from
Feb 14, 2021

Conversation

burdulixda
Copy link
Contributor

Hello again.

I fixed the SCSS code according to your suggestion and also added some test cases. I also wanna point out that I'm using this code in production now and seems to be working perfectly fine. WOFF fonts get .woff extension and 'woff' format, while TTF fonts get .ttf extension and 'truetype' format.

@Dan503
Copy link
Owner

Dan503 commented Feb 14, 2021

I've fixed up the tests. I was after new tests rather than modified old ones though the generator doesn't really lend itself well to doing multiple tests so I just added ttf to the existing test on that one.

I also wanna point out that I'm using this code in production now and seems to be working perfectly fine

The issue I saw was with how the code was handling the case of $types: 'ttf' 'woff'. As in multiple file types in the one rule.

I'm guessing you are only loading the one ttf file type in production which is why it would have worked for you.

@Dan503 Dan503 merged commit 895a846 into Dan503:develop Feb 14, 2021
@Dan503
Copy link
Owner

Dan503 commented Feb 14, 2021

Thanks for the fix. I've published it to npm as v1.1.2 now 🙂

@Dan503
Copy link
Owner

Dan503 commented Feb 14, 2021

For reference, the original PR #5

@burdulixda I've also added a contributing section in this release to readme.md now. Thanks for the suggestion.

@burdulixda
Copy link
Contributor Author

Thanks for this awesome mixin, cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants