Non mutable default in Spider.custom_settings

DamonGuo · Sep 2, 2014 · 77bd26a · 77bd26a
1 parent 16e62e9
commit 77bd26a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/scrapy/spider.py b/scrapy/spider.py
@@ -20,7 +20,7 @@ class Spider(object_ref):
     """
 
     name = None
-    custom_settings = {}
+    custom_settings = None
 
     def __init__(self, name=None, **kwargs):
         if name is not None:
@@ -69,7 +69,7 @@ def parse(self, response):
 
     @classmethod
     def update_settings(cls, settings):
-        settings.setdict(cls.custom_settings, priority='spider')
+        settings.setdict(cls.custom_settings or {}, priority='spider')
 
     @classmethod
     def handles_request(cls, request):