Improve plot_force and fix spec_updater
#227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 80.74% 80.95% +0.20%
==========================================
Files 85 85
Lines 5463 5465 +2
==========================================
+ Hits 4411 4424 +13
+ Misses 1052 1041 -11
Continue to review full report at Codecov.
|
|
Just lacks a small test :) |
glyg
reviewed
Mar 19, 2021
glyg
reviewed
Mar 19, 2021
glyg
reviewed
Mar 19, 2021
tests/draw/test_plt.py
Outdated
| @@ -15,7 +15,7 @@ | |||
| from tyssue import Sheet, config | |||
| from tyssue.draw.plt_draw import quick_edge_draw, sheet_view | |||
| from tyssue.draw.plt_draw import _face_color_from_sequence | |||
| from tyssue.draw.plt_draw import create_gif | |||
| from tyssue.draw.plt_draw import create_gif, plot_force | |||
There was a problem hiding this comment.
It's difficult to write test this morning..., I also forgot to put a test, in the test function... --'
|
You can add sheet.update_spec(model.specs) to have the correct columns (and a test that passes) |
|
Fridays are hard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.