Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new apis to get user notifications and bulk update status #855

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

Ishankoradia
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 48.83721% with 22 lines in your changes missing coverage. Please review.

Project coverage is 74.44%. Comparing base (b07abb1) to head (2e90c57).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ddpui/core/notifications_service.py 33.33% 14 Missing ⚠️
ddpui/api/notifications_api.py 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #855      +/-   ##
==========================================
- Coverage   74.63%   74.44%   -0.20%     
==========================================
  Files         191      191              
  Lines        7914     7949      +35     
==========================================
+ Hits         5907     5918      +11     
- Misses       2007     2031      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit ef19849 into main Sep 13, 2024
1 of 4 checks passed
@fatchat fatchat deleted the notifications-system-changes branch September 13, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants