Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the bug for fetching right dataflow against manual orgtask and also N+1 query #800

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Ishankoradia
Copy link
Contributor

@Ishankoradia Ishankoradia commented Aug 7, 2024

  • While fetching the orgtasks on transform page we were not doing dataflow_type = manual. So for the dbt run orgtask we could have fetched deployment id of any random pipeline also.
    I dont know how we missed it. I think we were lucky we got the right deployment_id with .first()
  • Also fixed the N+1 query here. Sentry email this morning.

@fatchat

@Ishankoradia Ishankoradia changed the title fixed and also N+1 query fixed the bug for fetching right dataflow against manual orgtask and also N+1 query Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.72%. Comparing base (88d9b85) to head (976dbbb).

Files Patch % Lines
ddpui/api/orgtask_api.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
+ Coverage   72.68%   72.72%   +0.03%     
==========================================
  Files         182      182              
  Lines        7429     7436       +7     
==========================================
+ Hits         5400     5408       +8     
+ Misses       2029     2028       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit 2f75552 into main Aug 8, 2024
3 of 4 checks passed
@fatchat fatchat deleted the bug-deploymentids-for-orgtask branch August 8, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants