Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling error edge case in discover_schema dalgo api #793

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

Ishankoradia
Copy link
Contributor

This was observerd in the schema change bug and sentry triggered an error for not handling this.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (90fb018) to head (37711da).

Files Patch % Lines
ddpui/ddpairbyte/airbyte_service.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   72.73%   72.68%   -0.06%     
==========================================
  Files         182      182              
  Lines        7362     7369       +7     
==========================================
+ Hits         5355     5356       +1     
- Misses       2007     2013       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit 1292ef6 into main Aug 6, 2024
1 of 2 checks passed
@fatchat fatchat deleted the edge-case-discove-schema-api branch August 6, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants