fix(node): avoid classifying filesystem EBUSY as SQLite busy - #78
Draft
Dailin521 wants to merge 1 commit into
Draft
fix(node): avoid classifying filesystem EBUSY as SQLite busy#78Dailin521 wants to merge 1 commit into
Dailin521 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent filesystem
EBUSYfailures from being misclassified as SQLite busy/locked errors in the Node CLI.Root cause
isSqliteBusyError()used a genericmessage.includes("busy")check. Node filesystem errors such as:therefore received the misleading
state_5.sqlite is currently in useguidance.Changes
SQLITE_BUSY*andSQLITE_LOCKED*codes.database is lockedanddatabase table is lockedmessages.EBUSYerrors unchanged.User impact
Journal/file sharing failures now retain their real filesystem diagnostic instead of telling users to close Codex because SQLite is busy.
Validation
node --test test/sqlite-error-classification.test.jsnpm test— 210 passedNon-goals and follow-up draft
This PR intentionally does not change rollback or recovery behavior.
A separate follow-up should investigate and design:
transaction-journal.jsonl;rollingBack;That work should remain separate because it changes concurrency and data-integrity behavior beyond this error-classification fix.