Skip to content

User card has odd margin attribute #16

Description

@amotl

Problem

The user card currently has a large spacing due to some margin setting which seems to be nailed to 80px.

image

Activity

  1. amotl commented on Jan 13, 2019

    @amotl
    Author

    Workaround

    This patch

    /* Fix DMT#16: Odd margin attribute with user card */
    #user-card .bio, #group-card .bio {
        margin-top: unset !important;
    }

    makes the issue go away:

    image

  2. sesemaya commented on Jan 16, 2019

    @sesemaya
    Collaborator

    Hmmm. I can't reproduce this problem. I'm assuming this is happening in the popup user info dialog after you click a user's avatar, but I can't see this problem in our Discourse. Does this happen on a specific page? Or does the user have some specific settings turned off/on?

  3. amotl commented on Jan 17, 2019

    @amotl
    Author

    Hi @sesemaya,

    thanks for getting back.

    I'm assuming this is happening in the popup user info dialog after you click a user's avatar

    Correct, sorry for being ambiguous about this detail. I recognize the cropped screenshots didn't help much finding out. Will try to do better.

    As we are running some modifications on top of your theme, we just double-checked whether this will also happen with the plain vanilla version without any other theme components activated. It does:

    image

    You can check this live at the Discourse instance we are currently working on. As far as we can recognize, it happens on every page.

    It's not a serious thing though, as we could mitigate it with the simple fix on the CSS level as outlined above. So, it will be a matter of curiosity to dig deeper on this. Let us know if we can help.

    Thanks,
    Andreas.

    P.S.: Please not that, while the site is currently on DMT vanilla w/o theme components, we will switch back to the modified variant soon.

  4. amotl commented on Jan 17, 2019

    @amotl
    Author

    We just found out it will only happen when Profile » About me is non-empty, as with the user profile of "discobot" and all others who configured it.

    When this field is left empty, the rendering is also fine:
    image

  5. sesemaya commented on Jan 18, 2019

    @sesemaya
    Collaborator

    Confirming this is indeed a bug. I'll get this fixed.

  6. sesemaya commented on Jan 21, 2019

    @sesemaya
    Collaborator

    This is fixed by 04b7e8b.

  7. amotl commented on Jan 22, 2019

    @amotl
    Author

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions