Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Character limit per line #44

Closed
LearningJer opened this issue Aug 25, 2023 · 3 comments
Closed

Fix Character limit per line #44

LearningJer opened this issue Aug 25, 2023 · 3 comments
Labels
enhancement New feature or request fixed in next release Should be fixed or added in the next release

Comments

@LearningJer
Copy link

LearningJer commented Aug 25, 2023 •
edited
Loading

It's entirely possible I overlooked it but, is there a way to set a custom character limit per line? I am trying to have just a single line with a max of 18 characters per sentence.

Edit*
This is for the audio transcriptions
@Dadangdut33
Copy link
Owner

there is no setting for that. But i'll add it now, thanks for the suggestion 👍

@Dadangdut33 Dadangdut33 added the enhancement New feature or request label Aug 27, 2023
Dadangdut33 added a commit that referenced this issue Sep 4, 2023
@Dadangdut33
added setting for #44 (not yet implemented)
9d4a67c 
- setting widgets that use "command" in the widget is now configured after the value is set to prevent multiple callings to the commands
- modular textbox setting code and change to its looks
@Dadangdut33 Dadangdut33 added the fixed in dev branch Fixed or added but not yet released label Sep 5, 2023
@Dadangdut33 Dadangdut33 mentioned this issue Oct 22, 2023
Merged
Dadangdut33 added a commit that referenced this issue Nov 7, 2023
@Dadangdut33
Merge pull request #47 from Dadangdut33/dev
5f459a5 
1.3.0

addresses the following #10 #27 #31 #32 #33 #34 #35 #36 #40 #41 #42 #44 #46
@LearningJer
Copy link
Author

Thanks for updating this! Though I am not sure it is what I meant that was updated. I was hoping for something similar to this?
https://youtu.be/GIh9imtq-fI?si=x0XQhHYWHevsUTg0&t=98

Where the user would be able to set the max character limit per line on a transcribed audios subtitle track. Unless I missed something again in this latest patch. Thanks again!

@Dadangdut33
Copy link
Owner

whoops, it seems that at some point the whole character limit was broken.

I added it for the record session and it should have worked like this
image

I also noticed that it is possible to limit it for the file import using split_by_length(), i guess i will add it too in the next release alongside the bug fix.

Thanks for letting me know of this bug

@Dadangdut33 Dadangdut33 reopened this Nov 15, 2023
@Dadangdut33 Dadangdut33 changed the title Set Character limit? Fix Character limit per line Nov 15, 2023
@Dadangdut33 Dadangdut33 added fixed in next release Should be fixed or added in the next release and removed fixed in dev branch Fixed or added but not yet released labels Nov 15, 2023
Dadangdut33 added a commit that referenced this issue Nov 15, 2023
@Dadangdut33
fix character limit per line #44
1f8ac8d
Dadangdut33 added a commit that referenced this issue Nov 27, 2023
@Dadangdut33
add split/limit segment for file import #44
bad46b0 
- fix tsv saving
- move the export format to its own page
- move the hacky unicode to constant variable
- separate setting to show audio visualizer for record and setting
- translated words now match the way its supposed to be originally (the spacing should be in front not in the back)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fixed in next release Should be fixed or added in the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dadangdut33 @LearningJer