Skip to content

Commit

Permalink
mm/hugetlb: remove unnecessary memory fetch in PageHeadHuge()
Browse files Browse the repository at this point in the history
Commit f1e6155 ("mm: pack compound_dtor and compound_order into one
word in struct page") changed compound_dtor from a pointer to an array
index in order to pack it.  To check if page has the hugeltbfs
compound_dtor, we can just compare the index directly without fetching the
function pointer.  Said commit did that with PageHuge() and we can do the
same with PageHeadHuge() to make the code a bit smaller and faster.

Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Neha Agarwal <nehaagarwal@google.com>
Link: http://lkml.kernel.org/r/20200311172440.6988-1-vbabka@suse.cz
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
tehcaster authored and torvalds committed Apr 2, 2020
1 parent 353b2de commit d4af73e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mm/hugetlb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1528,7 +1528,7 @@ int PageHeadHuge(struct page *page_head)
if (!PageHead(page_head))
return 0;

return get_compound_page_dtor(page_head) == free_huge_page;
return page_head[1].compound_dtor == HUGETLB_PAGE_DTOR;
}

/*
Expand Down

0 comments on commit d4af73e

Please sign in to comment.