Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS Not Compatible with SC Labs #947

Merged
merged 1 commit into from
Aug 1, 2023
Merged

DS Not Compatible with SC Labs #947

merged 1 commit into from
Aug 1, 2023

Conversation

numbap
Copy link
Contributor

@numbap numbap commented Jul 26, 2023

DS-133548(Jira Issue)-A###(component ID)-(DS Not Compatible with SC Labs)

Reminder: Add all changes for this PR to the CHANGELOG.md

Main Reviewer: @nibivi77 @shawn320

Description & Background Context:

Added HelpIcon to index.ts so that it can be accessed from client applications.

Where should the reviewer start?

File name: index.ts

How should this be tested?

Pack a zip of this design system version, and add it to another project. You should be able to add the without crashing the application.

Are there any breaking changes?

@shawn320 shawn320 changed the base branch from main to develop July 31, 2023 18:45
Copy link
Contributor

@shawn320 shawn320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@numbap numbap merged commit afcd2b9 into develop Aug 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants