feat:added new font #882
Merged
feat:added new font #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-127033(Jira Issue)-A###(component ID)-(ds-caption-heading1)
Reminder: Add all changes for this PR to the CHANGELOG.md
Main Reviewer: @
Description & Background Context:
This creates a new Typography style called ds-caption-heading1
Where should the reviewer start?
File name: src/stories/styles/Typography/Typography.js
How should this be tested?
Under typography, check to make sure that ds-caption-heading1 has the following characteristics:
font-family: Lato, font-serif
font-size: 22px
line-height: 33px
font-weight: 400
color: grey85a
Are there any breaking changes?
no