Skip to content

Commit

Permalink
Merge pull request #631 from DTS-STN/revert-629-target-prop
Browse files Browse the repository at this point in the history
Revert "feat: add target prop to allow user to specify where to open …
  • Loading branch information
zeddotes authored Jan 17, 2023
2 parents 921e65c + c7acb88 commit 973bac0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 17 deletions.
10 changes: 0 additions & 10 deletions src/components/Footer/Footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export function Footer(props) {
isAuthenticated,
contactLink,
brandLinks,
target,
} = props;
let langLand =
lang === EN ? ENlandscapeLinks : lang === FR ? FRlandscapeLinks : [];
Expand Down Expand Up @@ -129,7 +128,6 @@ export function Footer(props) {
href={value.landscapeLink}
text={value.landscapeLinkText}
linkStyle="smfooterWhite"
target={target}
yt
/>
</li>
Expand All @@ -154,7 +152,6 @@ export function Footer(props) {
text={mscaContactUs.mscaFooterContactUsText}
href={contactLink}
linkStyle="smfooterWhite"
target={target}
/>
</section>
</div>
Expand Down Expand Up @@ -191,7 +188,6 @@ export function Footer(props) {
href={value.href}
text={value.text}
linkStyle="smfooterBlue"
target={target}
/>
</li>
);
Expand Down Expand Up @@ -228,7 +224,6 @@ export function Footer(props) {

Footer.defaultProps = {
lang: EN,
contactLink: "https://www.canada.ca/en/contact.html",
brandLinks: [
{
id: "link1",
Expand Down Expand Up @@ -301,9 +296,4 @@ Footer.propTypes = {
href: PropTypes.string,
})
),

/**
* Specifies where to open the linked document
*/
target: PropTypes.string,
};
6 changes: 0 additions & 6 deletions src/components/Footer/Footer.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ EnglishAuth.args = {
id: "footer",
lang: "en",
btnLink: "/",
contactLink: "https://www.canada.ca/en/contact.html",
isAuthenticated: true,
target: "_blank",
brandLinks: [
{
id: "link1",
Expand All @@ -37,9 +35,7 @@ FrenchAuth.args = {
id: "footer",
lang: "fr",
btnLink: "/",
contactLink: "https://www.canada.ca/fr/contact.html",
isAuthenticated: true,
target: "_blank",
brandLinks: [
{
id: "link1",
Expand All @@ -59,7 +55,6 @@ EnglishNonAuth.args = {
id: "footer",
lang: "en",
btnLink: "/",
target: "_blank",
brandLinks: [
{
id: "link1",
Expand Down Expand Up @@ -94,7 +89,6 @@ FrenchNonAuth.args = {
id: "footer",
lang: "fr",
btnLink: "/",
target: "_blank",
brandLinks: [
{
id: "link1",
Expand Down
2 changes: 1 addition & 1 deletion src/components/TableContent/TableContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function TableContent(props) {
<Link
href={option.link}
id={`tableLink${index + 1}`}
text={option.name}
text={`[${option.name}]`}
linkStyle="cardActionLink"
/>
</li>
Expand Down

0 comments on commit 973bac0

Please sign in to comment.