fix: add react and react-dom to external in rollup

DTS-STN · Jul 31, 2023 · 8ad6568 · 8ad6568
1 parent 976a8b9
commit 8ad6568
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/package.json b/package.json
@@ -80,6 +80,10 @@
       "last 1 safari version"
     ]
   },
+  "peerDependencies": {
+    "react": "^17.0.0 || ^18.0.0",
+    "react-dom": "^17.0.0 || ^18.0.0"
+  },
   "devDependencies": {
     "@babel/cli": "^7.14.5",
     "@babel/core": "^7.14.5",

diff --git a/rollup.config.js b/rollup.config.js
@@ -51,6 +51,8 @@ export default [
     // anything "external" will not be included into the generated bundle
     // https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
     external: [
+      "react",
+      "react-dom",
       // regular dependencies should not be included as they will be automatically installed by the consuming application
       ...Object.keys(pkg.dependencies || {}),
       // peer dependencies should not be included as they are expected to be provided by the consuming application