fix: made top-level compoinent into button

DTS-STN · Feb 17, 2023 · 60d66cd · 60d66cd
1 parent 84b84c3
commit 60d66cd
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/src/components/Button/Button.js b/src/components/Button/Button.js
@@ -5,10 +5,7 @@ import { Image } from "../Image/Image";
 export function Button(props) {
   const style = "ds-btn-" + props.styling;
   return props.href === "no ref" ? (
-    <div
-      role="button"
-      tabIndex={0}
-      onKeyUp={props.onClick}
+    <button
       className={`ds-flex ds-flex-row ${style} focus:ds-ring focus:ds-ring-offset-4 ${props.className} `}
       onClick={props.onClick}
       type={props.type}
@@ -17,18 +14,18 @@ export function Button(props) {
       {...props.attributes}
     >
       {props.icon && !props.iconEnd ? (
-        <div className="ds-grid ds-place-items-center ds-h-8 ds-w-8">
+        <span className="ds-grid ds-place-items-center ds-h-8 ds-w-8">
           <Image className="ds-pr-2" src={props.icon} alt={props.iconAltText} />
-        </div>
+        </span>
       ) : undefined}
       {props.text}
       {props.children}
       {props.icon && props.iconEnd ? (
-        <div className="ds-grid ds-place-items-center ds-h-8 ds-w-8">
+        <span className="ds-grid ds-place-items-center ds-h-8 ds-w-8">
           <Image className="ds-pl-2" src={props.icon} alt={props.iconAltText} />
-        </div>
+        </span>
       ) : undefined}
-    </div>
+    </button>
   ) : (
     <a
       href={props.href}