Skip to content

Commit

Permalink
fix: Update French links, change hard-coded heading
Browse files Browse the repository at this point in the history
  • Loading branch information
shawn320 committed Feb 22, 2023
1 parent 7446999 commit 0706820
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 12 deletions.
8 changes: 6 additions & 2 deletions src/components/Footer/Footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export function Footer(props) {
aria-labelledby="accessibleSectionHeader1"
>
<h2 className="ds-sr-only" id="accessibleSectionHeader1">
About Government
{lang === EN
? ENlandscapeLinks.aboutGovernment
: FRlandscapeLinks.aboutGovernment}
</h2>
<ul className="sm:ds-grid sm:ds-grid-cols-3 ds-flex ds-flex-col ds-gap-1 ds-text-xs">
{" "}
Expand Down Expand Up @@ -173,7 +175,9 @@ export function Footer(props) {
aria-labelledby="accessibleSectionHeader2"
>
<h2 className="ds-sr-only" id="accessibleSectionHeader2">
About this site
{lang === EN
? ENlandscapeLinks.aboutSite
: FRlandscapeLinks.aboutSite}
</h2>
<ul className="ds-flex ds-flex-col sm:ds-flex-row">
{brandLinks.map(({ href, text, onClick }, index) => {
Expand Down
2 changes: 2 additions & 0 deletions src/translations/en.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"ENlandscapeLinks": {
"aboutGovernment": "About Government",
"aboutSite": "About this site",
"link1": "Contact us",
"link2": "News",
"link3": "Prime Minister",
Expand Down
22 changes: 12 additions & 10 deletions src/translations/fr.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"FRlandscapeLinks": {
"aboutGovernment": "Au sujet du gouvernement",
"aboutSite": "À propos de ce site",
"link1": "Contactez-nous",
"link4": "Ministères et organismes",
"link7": "Fonction publique et force militaire",
Expand All @@ -10,13 +12,13 @@
"link6": "À propos du gouvernement",
"link9": "Gouvernement ouvert",
"link1link": "https://www.canada.ca/fr/contact.html",
"link4link": "https://www.canada.ca/fr/government/dept.html",
"link7link": "https://www.canada.ca/fr/government/publicservice.html",
"link2link": "https://www.canada.ca/fr/news.html",
"link5link": "https://www.canada.ca/fr/government/system/laws.html",
"link8link": "https://www.canada.ca/fr/transparency/reporting.html",
"link4link": "https://www.canada.ca/fr/gouvernement/min.html",
"link7link": "https://www.canada.ca/fr/gouvernement/fonctionpublique.html",
"link2link": "https://www.canada.ca/fr/nouvelles.html",
"link5link": "https://www.canada.ca/fr/gouvernement/systeme/lois.html",
"link8link": "https://www.canada.ca/fr/transparence/rapports.html",
"link3link": "https://pm.gc.ca/fr",
"link6link": "https://www.canada.ca/fr/government/system.html",
"link6link": "https://www.canada.ca/fr/gouvernement/systeme.html",
"link9link": "https://open.canada.ca/fr"
},
"FRbrandLinks": {
Expand All @@ -25,11 +27,11 @@
"link3": "À propos de Canada.ca",
"link4": "Avis",
"link5": "Confidentialité",
"link1link": "https://www.canada.ca/fr/social.html",
"link1link": "https://www.canada.ca/fr/sociaux.html",
"link2link": "https://www.canada.ca/fr/mobile.html",
"link3link": "https://www.canada.ca/fr/government/about.html",
"link4link": "https://www.canada.ca/fr/transparency/terms.html",
"link5link": "https://www.canada.ca/fr/transparency/privacy.html"
"link3link": "https://www.canada.ca/fr/gouvernement/a-propos.html",
"link4link": "https://www.canada.ca/fr/transparence/avis.html",
"link5link": "https://www.canada.ca/fr/transparence/confidentialite.html"
},
"mscaFooterHeading": "Mon dossier Service Canada",
"mscaContactUs": {
Expand Down

0 comments on commit 0706820

Please sign in to comment.