-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object Detection Train #840
base: nextjs
Are you sure you want to change the base?
Conversation
frontend/src/features/Train/features/Tabular/components/TabularReviewStep.tsx
Show resolved
Hide resolved
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I received an error that looked something like this when spinning up frontend:
import FilerobotImageEditor from"./components/AssemblyPoint";import{TABS_IDS,TOOLS_IDS}from"./utils/constants";export{TABS_IDS as TABS,TOOLS_IDS as TOOLS};export default FilerobotImageEditor;
^^^^^^
SyntaxError: Cannot use import statement outside a module
It may be because of the React Filerobot Image Editor not supporting nextjs directly. Try using a dynamic import: scaleflex/filerobot-image-editor#228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks pretty good! Just a few minor things that are still there. Is there any way for the user to upload images to edit in the image editor in the dataset step, or does that image editor only work for the one image with mountains that it defaults to?
frontend/src/features/Train/features/ObjectDetection/constants/detectionConstants.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/Train/features/ObjectDetection/constants/detectionConstants.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/Train/features/ObjectDetection/constants/detectionConstants.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/Train/features/ObjectDetection/constants/detectionConstants.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/Train/features/ObjectDetection/constants/detectionConstants.ts
Outdated
Show resolved
Hide resolved
@dwu359 I forgot to mention this earlier but you can upload images to edit and the mountain image is just a default backdrop. As for changing the mountain image, in the past I've changed it to other images such as a blank image but it was buggy so I changed it back. |
…ayground into object-detection-train
@dwu359 austin is working on integratimg tui image editor in place of file robot |
Can you update the screenshot @Dashrekker? I think tui uses a dark background color, so that screenshot is old |
@dwu359 should be resolved. @Dashrekker removed the react-filerobot-image-editor deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I found uploading an image to be a little confusing though. When the user loads an image into the image editor, could you add an additional option to directly upload a file through the user's filesystem? The filename & jpg/png dropdown are probably not needed either, since that can automatically be inferred from either the image editor or thru the user's filesystem.
SonarCloud Quality Gate failed. 3 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Implemented object detection trainspace.