Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Detection Train #840

Open
wants to merge 28 commits into
base: nextjs
Choose a base branch
from
Open

Object Detection Train #840

wants to merge 28 commits into from

Conversation

Dashrekker
Copy link
Collaborator

@Dashrekker Dashrekker commented Jun 26, 2023

Implemented object detection trainspace.
image
image

@Dashrekker Dashrekker marked this pull request as ready for review June 26, 2023 16:45
@farisdurrani
Copy link
Member

lgtm

@Dashrekker Dashrekker linked an issue Jun 28, 2023 that may be closed by this pull request
Copy link
Contributor

@dwu359 dwu359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I received an error that looked something like this when spinning up frontend:

import FilerobotImageEditor from"./components/AssemblyPoint";import{TABS_IDS,TOOLS_IDS}from"./utils/constants";export{TABS_IDS as TABS,TOOLS_IDS as TOOLS};export default FilerobotImageEditor;
^^^^^^

SyntaxError: Cannot use import statement outside a module

It may be because of the React Filerobot Image Editor not supporting nextjs directly. Try using a dynamic import: scaleflex/filerobot-image-editor#228

Copy link
Contributor

@dwu359 dwu359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks pretty good! Just a few minor things that are still there. Is there any way for the user to upload images to edit in the image editor in the dataset step, or does that image editor only work for the one image with mountains that it defaults to?

@Dashrekker
Copy link
Collaborator Author

@dwu359 I forgot to mention this earlier but you can upload images to edit and the mountain image is just a default backdrop. As for changing the mountain image, in the past I've changed it to other images such as a blank image but it was buggy so I changed it back.

@karkir0003
Copy link
Member

@dwu359 austin is working on integratimg tui image editor in place of file robot

@karkir0003 karkir0003 added enhancement New feature or request full-stack full stack task labels Jul 15, 2023
@farisdurrani
Copy link
Member

farisdurrani commented Jul 28, 2023

Can you update the screenshot @Dashrekker? I think tui uses a dark background color, so that screenshot is old

@karkir0003
Copy link
Member

I received an error that looked something like this when spinning up frontend:

import FilerobotImageEditor from"./components/AssemblyPoint";import{TABS_IDS,TOOLS_IDS}from"./utils/constants";export{TABS_IDS as TABS,TOOLS_IDS as TOOLS};export default FilerobotImageEditor;
^^^^^^

SyntaxError: Cannot use import statement outside a module

It may be because of the React Filerobot Image Editor not supporting nextjs directly. Try using a dynamic import: scaleflex/filerobot-image-editor#228

@dwu359 should be resolved. @Dashrekker removed the react-filerobot-image-editor deps

@karkir0003 karkir0003 requested a review from dwu359 July 28, 2023 02:24
Copy link
Contributor

@dwu359 dwu359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I found uploading an image to be a little confusing though. When the user loads an image into the image editor, could you add an additional option to directly upload a file through the user's filesystem? The filename & jpg/png dropdown are probably not needed either, since that can automatically be inferred from either the image editor or thru the user's filesystem.

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 25 Code Smells

No Coverage information No Coverage information
29.8% 29.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request full-stack full stack task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Object Detection Training Flow
4 participants