fix(connect): drop dead wake_console call (404 + 2s sleep every connect)#69
Merged
Conversation
…onnect
create_session invoked wake_console on every connect. That method POSTed
/v6/servers/home/{id}/wake — a guaranteed 404 (cloud wake is dead; even
Greenlight can't remote-wake a standby console) — then unconditionally
slept 2s "to let the console wake". Net effect on every stream start,
including to an already-on console: a wasted failed round-trip plus a
hard 2-second delay for zero benefit. Remove the method and its call.
Verified: cargo clippy --all-targets -D warnings clean; cargo test 134 passed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
create_sessioninvokedwake_consoleon every connect. That method POSTed/v6/servers/home/{id}/wake— a guaranteed 404 (cloud wake is dead; even Greenlight can't remote-wake a standby console) — then unconditionally slept 2 seconds "to let the console wake". Net effect on every stream start, including to an already-on console: a wasted failed round-trip plus a hard 2-second delay for zero benefit.Fix
Remove
wake_consoleand its single call site.create_sessionnow proceeds straight from its log line to session creation.Why not fix the wake instead?
A feasibility spike against a real Series X confirmed the raw SmartGlass local power-on packet is ignored by modern console firmware (remote wake requires an authenticated CDP path), and the cloud
/wakeendpoint is dead. Real wake-on is shelved; this PR just removes the dead code that slowed every connect.Verification
cargo clippy --all-targets -- -D warnings— cleancargo test— 134 passed, 0 failed🤖 Generated with Claude Code