Remove transaction from fetch work API. #2843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen the transaction to fail, resulting in exceptions/500s. Part of fixing DOMjudge#2848. There is also no need to have a transaction at all. We now do check after the update whether we won instead and if not, tell the judgehost to try again. Before this, I could with 4 judgedaemons on my laptop reliably reproduce the error by just judging the example problems, seeing it ~5 times for all ~100 submissions. Afterwards, I ran this 10 times and didn't encounter any error.
meisterT
force-pushed
the
lesstransaction
branch
from
c06ee8a to
7ce48c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen the transaction to fail, resulting in exceptions/500s.
There is also no need to have a transaction at all. We now do check after the update whether we won instead and if not, tell the judgehost to try again.