Skip to content

Replace Ace with Monaco editor #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/jobs/data/codespellignorefiles.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
./.github/jobs/uploadcodecov.sh
./webapp/vendor
./webapp/public/bundles
./webapp/public/js/ace
./webapp/public/js/monaco
./webapp/templates/bundles
./webapp/var/cache
./webapp/migrations/Version20230122090005.php
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:

- name: Remove upstream code
run: |
rm -rf webapp/public/js/ace doc/manual/_static
rm -rf webapp/public/js/monaco doc/manual/_static

- name: Chown everything to the current runner user
if: ${{ contains(env.COMPILED, matrix.language) }}
Expand Down
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Version 8.4.0DEV
---------------------------
- Get rid of 'internal' data source mode, always requiring - but auto
generating - external ID's for all entities to simplify event logic.
- Replace ACE editor with Monaco editor and also use it for diffs.

Version 8.3.0 - 31 May 2024
---------------------------
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ DOMjudge manual.

The following JavaScript libraries/snippets are included:
- coloris: Momo Bassit, licensed under the MIT license, see COPYING.MIT.
- Ace editor: licensed under the BSD licence, see COPYING.BSD.
- Monaco editor: licensed under the MIT license, see COPYING.MIT.

The default validator from the Kattis problemtools package is
included, licensed under the MIT licence, see COPYING.MIT.
Expand Down
17 changes: 0 additions & 17 deletions webapp/public/js/ace/ace.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-beautify.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-code_lens.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-elastic_tabstops_lite.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-emmet.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-error_marker.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-keybinding_menu.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-language_tools.js

This file was deleted.

8 changes: 0 additions & 8 deletions webapp/public/js/ace/ext-linking.js

This file was deleted.

Loading
Loading