Allow setting activation time in contest.yaml #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldering
reviewed
Nov 14, 2022
vmcj
force-pushed
the
import_contest_activatetime
branch
6 times, most recently
from
5a0cc6a to
047d2ec
Compare
nickygerritsen
approved these changes
Jan 30, 2023
eldering
reviewed
Feb 19, 2023
vmcj
force-pushed
the
import_contest_activatetime
branch
2 times, most recently
from
b2ff378 to
318b9b9
Compare
|
I had to break the import of the old import format for this, I assume we want to support that again as we also still support the TSV files? |
eldering
reviewed
May 6, 2023
vmcj
force-pushed
the
import_contest_activatetime
branch
from
1739ea3 to
8c24f05
Compare
This is useful to export one contest and use that directly for import in another instance. Those can also be used in downstream systems to lock/unlock the client, alert that the ceremony can start etc. Also expose relative times and absolute as that makes parsing easier. Did not implement the activation_duration as there is no real usecase for it.
Also add tests to check if the (de)activation time is correctly set via API. Order based on most recent CLICS spec naming convention
vmcj
force-pushed
the
import_contest_activatetime
branch
from
764928c to
9685479
Compare
|
Thanks for merging this! 😄 Question: since either |
|
It's For most other properties you can refer to https://ccs-specs.icpc.io/draft/contest_api#interface-specification, but these are our own specification. |
eldering
added a commit
that referenced
this pull request
May 8, 2023
eldering
added a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1719
I've added some more times to the contest which might be useful. If we can expose a property but currently it's null, should we display as null or do we omit it from the response? I've now chosen to omit as that is also easier to parse for downstream clients. It's easy to crash an a missing key and fix it, but finding why you get a strange time when converting null to something else is slightly harder IMO.