[DO NOT MERGE] This is the same as PR #123 - testing to see if CI will run #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed 0.5 pixel offsets * fixed 0.5 pixel offsets in tests
Test camera model
* added observer x-distance test. * added rotation tests. * removed extra comments * changed to use pi constant
* added observer x-distance test. * added rotation tests. * removed extra comments * changed to use pi constant * added semi-major and semi-minor axis tests. * comment edits
* Added framing test for setFocalPlane. Also enabled the testing of protected member functions, and modification of the ISD within the test fixture. * Added jupyter_notebooks folder to CSM-CameraModel. * Refactored setFocalPlane test so that the ISD changes are made local to the test (and not global). * Refactored tests for setFocalPlane, distortionJacobian to modify Isd parameters and use them in tests. * Added two new failing tests and a printIsd() helper function in the FrameIsdTest fixture to help with debugging. * Fixed the failing tests. They were due to the Jacobian being unexpectedly singular.
* Added framing test for setFocalPlane. Also enabled the testing of protected member functions, and modification of the ISD within the test fixture. * Added jupyter_notebooks folder to CSM-CameraModel. * Refactored setFocalPlane test so that the ISD changes are made local to the test (and not global). * Refactored tests for setFocalPlane, distortionJacobian to modify Isd parameters and use them in tests. * Added two new failing tests and a printIsd() helper function in the FrameIsdTest fixture to help with debugging. * Fixed the failing tests. They were due to the Jacobian being unexpectedly singular. * Added a createModel function to the FrameIsdTest fixture. Also added 2 more tests. * Made requested changes to clean up tests, and added a parameterized testing fixture. * Removed a debugging statement in the JacobianTest.
… windows 10 machine with VS2017. (DOI-USGS#106)
Added ISD spec to README
* Modified git ignore to ignore all iPython nb checkpoints * Added a check in ls ground to image for samples outside the ccd.
* Swaps from error to warning on out of bounds. * Fixes the correct error/warning
* Initial updates for refactoring the UsgsAstroFramePlugin * Jacobian1 test now passing * All coefficients test now passing * More testing passing * Down to 6 failing tests * Fixed failing position-offset tests * Update to strip out full-paths and also we're down to one failing test * Fixed last failing test by updating canModelBeConstructedFromIsd to load the json ISD into a csm::Isd object if it has not already been loaded * Updated based on review comments
krlberry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kelvin and I are seeing different test output for this when cloning locally. This PR is here to see what the CI output is and (hopefull) I can use this to figure out what's going wrong.