Refactor lines length units #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with mambaforge install and pip and git SSL certificate handling; point to doi-usgs docs and code state now that GitHub Actions are working for the doi-usgs domain
* Replace attr_length_units arg with separate asum_units and width_units args * Rename attr_height_units arg to elevation_units * Use crs instead of epsg or proj_str
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #147 +/- ##
===========================================
- Coverage 86.50% 86.45% -0.05%
===========================================
Files 19 19
Lines 4186 4180 -6
===========================================
- Hits 3621 3614 -7
- Misses 565 566 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the attr_length_units and attr_height_units args to the Lines class into separate arguments for width, arbolate sum and elevation. This allowed for some clean-up of the arbolate sum and channel width-related code in
Lines.to_sfr()that will hopefully make it more robust.Refactoring of epsg and proj_str referances to a single 'crs' reference (in parallel of the recent change in Flopy) is also included.