ACE_INET_Addr::set errantly succeeds when ACE_LACKS_GETSERVBYNAME
#2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitza-oci
previously approved these changes
Jun 21, 2023
|
Can you extend a unit test for this? |
jrw972
force-pushed
the
port0-ace-lacks-getservbyname
branch
from
56aaafb
to
0230ace
Compare
jwillemsen
reviewed
Jun 21, 2023
Problem
-------
Calling `set("1.2.3.4")` on an ACE_INET_Addr eventually tries to part
it as a port name. When `ACE_LACKS_GETSERVBYNAME`, this succeeds
returning port number 0 with the reset address.
When port names are not expected, this breaks a useful idiom of
parsing addresses that may or may not contain port numbers:
ACE_INET_Addr addr;
if (addr.set(x) == 0) {
// Success, address contained a port number
} else if (addr.set(u_short(0), x) == 0) {
// Success, address did not contain a port number.
} else {
// Fail
}
Solution
--------
Return -1 for the port number when `ACE_LACKS_GETSERVBYNAME`.
jrw972
force-pushed
the
port0-ace-lacks-getservbyname
branch
from
0230ace
to
395f5e5
Compare
iguessthislldo
approved these changes
Jun 26, 2023
mitza-oci
pushed a commit
to mitza-oci/ACE_TAO
that referenced
this pull request
Jun 27, 2023
…yname `ACE_INET_Addr::set` errantly succeeds when ACE_LACKS_GETSERVBYNAME (cherry picked from commit a65d91c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Calling
set("1.2.3.4")on an ACE_INET_Addr eventually tries to part it as a port name. WhenACE_LACKS_GETSERVBYNAME, this succeeds returning port number 0 with the reset address.When port names are not expected, this breaks a useful idiom of parsing addresses that may or may not contain port numbers:
Solution
Return -1 for the port number when
ACE_LACKS_GETSERVBYNAME.