[WIP] Start to adding some tests mechanism and python standards #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4383
force-pushed
the
unittest
branch
2 times, most recently
from
a0908ea to
a64f828
Compare
4383
changed the title
|
Wait before merge this, I think a better approach can be to introduce first some unit tests and after apply the python best practices (pep8) etc... to avoid errors if exists. |
Start to prepare project for testing (unit test/functional test/best
practices):
- adding tox env
- introduce unit test detection (need to implement unit tests)
- code coverage (need to implement unit tests)
- format code by using black and zimports
- fixing some PEP8 errors (need to continue to fix others)
- add flake8 rules
- adding travis config
- move some functions with debtcollector
|
Abandon these changes to split them into other PR topics like this one => #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to prepare project for testing (unit test/functional test/best
practices):
- adding tox env
- introduce unit test detection (need to implement unit tests)
- code coverage (need to implement unit tests)
- format code by using black and zimports
- fixing some PEP8 errors (need to continue to fix others)
- add flake8 rules
- adding travis config
If you accept these changes you also need to activate travis-ci to trigger tests automatically on push and pull requests.
I've start to fix the PEP8 errors but many still exist and need to be fixed.