Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DMTF/python-redfish-library
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: abf1571
Choose a base ref
...
head repository: DMTF/python-redfish-library
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ef8ec2a
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 12, 2024

  1. Optional Connection upon Client Instantiation 

    This allows a user to create a client without _knowing_ the IP they are
connecting to up front. It gives the user the ability to create and pass
around a client object as needed. Additionally, the default behavior is
preserved.

* Added `check_connectivity` keyword arg to `RestClientBase`.
* Added `check_connectivity` keyword arg to `HTTPClient`.
* Added `check_connectivity` keyword arg to `redfish_client` function.
* Conditionally execute `get_root_object` during client instantiation
based on the value of `check_connectivity`.
* Catch the resultant `AttributeError` in the case that `self.root` was
not set due to `check_connectivity` being set to `False`.
* Small test refactor, added `setUp` method to `TestRedFishClient` class
to make commonly used attributes members of the test case.
* Added new test for this functionality.

Signed-off-by: Justin Palmer <jpavlav@gmail.com>
    @jpavlav
    jpavlav committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bce8670 View commit details
    Browse the repository at this point in the history

  2. Issue #163: Feedback Update 

    * Ensure that the `root` data/response added as attributes by the
`get_root_object` method are cached when `login` is called.
* Added new test to cover this case.

Signed-off-by: Justin Palmer <jpavlav@gmail.com>
    @jpavlav
    jpavlav committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ef8ec2a View commit details
    Browse the repository at this point in the history
Loading