Skip to content

hotfix on v.1.0.3 synchronize #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 8, 2021
Merged

hotfix on v.1.0.3 synchronize #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
26f92d1
Merge pull request #34 from DMS-SMS/develop
parkjinhong03 Jan 26, 2021
866d451
Merge pull request #35 from DMS-SMS/develop
parkjinhong03 Feb 5, 2021
1e66580
[ADD] <main.go> Add setting router validator to custom validator
parkjinhong03 Feb 8, 2021
cd76f05
[MODIFY] <middleware/request_validator.go> Change type to pointer in …
parkjinhong03 Feb 8, 2021
f51ac48
Merge pull request #36 from DMS-SMS/hotfix
parkjinhong03 Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ func main() {
middleware.GinHResponseWriter(), // change ResponseWriter in *gin.Context to custom writer overriding that (add in v.1.0.3)
middleware.TracerSpanStarter(apiTracer), // start, end top span of tracer & set log, tag about response (add in v.1.0.3)
)
router.Validator = validator.New()

// routing auth service API
authRouter := router.CustomGroup("/", middleware.LogEntrySetter(authLogger))
Expand Down
10 changes: 5 additions & 5 deletions middleware/request_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,16 @@ func (r *requestValidator) RequestValidator(h gin.HandlerFunc) gin.HandlerFunc {
}

switch req.(type) {
case entity.GetScheduleRequest, entity.GetTimeTableRequest:
case *entity.GetScheduleRequest, *entity.GetTimeTableRequest:
if err := c.ShouldBindUri(req); err != nil {
respFor400["code"] = code.FailToBindRequestToStruct
respFor400["message"] = fmt.Sprintf("failed to bind uri in request into golang struct, err: %v", err)
c.AbortWithStatusJSON(http.StatusBadRequest, respFor400)
return
}
case entity.GetClubsSortByUpdateTimeRequest, entity.GetRecruitmentsSortByCreateTimeRequest, entity.GetStudentOutingsRequest,
entity.GetOutingWithFilterRequest, entity.GetAnnouncementsRequest, entity.GetPlaceWithNaverOpenAPIRequest,
entity.GetStudentUUIDsWithInformRequest, entity.GetTeacherUUIDsWithInformRequest, entity.GetParentUUIDsWithInformRequest:
case *entity.GetClubsSortByUpdateTimeRequest, *entity.GetRecruitmentsSortByCreateTimeRequest, *entity.GetStudentOutingsRequest,
*entity.GetOutingWithFilterRequest, *entity.GetAnnouncementsRequest, *entity.GetPlaceWithNaverOpenAPIRequest,
*entity.GetStudentUUIDsWithInformRequest, *entity.GetTeacherUUIDsWithInformRequest, *entity.GetParentUUIDsWithInformRequest:
if err := c.ShouldBindQuery(req); err != nil {
respFor400["code"] = code.FailToBindRequestToStruct
respFor400["message"] = fmt.Sprintf("failed to bind query parameter in request into golang struct, err: %v", err)
Expand Down Expand Up @@ -106,7 +106,7 @@ func (r *requestValidator) RequestValidator(h gin.HandlerFunc) gin.HandlerFunc {
}

switch req.(type) {
case *entity.GetStudentUUIDsWithInformRequest, *entity.GetTeacherUUIDsWithInformRequest, *entity.GetParentUUIDsWithInformRequest:
case **entity.GetStudentUUIDsWithInformRequest, **entity.GetTeacherUUIDsWithInformRequest, **entity.GetParentUUIDsWithInformRequest:
emptyValue := reflect.New(reflect.TypeOf(req).Elem()).Elem().Interface()
if reflect.DeepEqual(reflect.ValueOf(req).Elem().Interface(), emptyValue) {
respFor400["code"] = code.IntegrityInvalidRequest
Expand Down