Bootstrapped Accordions on Write Plan page#629
Merged
jollopre merged 2 commits intoDMPRoadmap:CDL-MVPfrom Sep 8, 2017
Merged
Conversation
- Bootstrapped the Write Plan page accordions - Rebased with latest from CDL-MVP bootstrapped the phases accordion DMPRoadmap#567 added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap#567 finished Bootstrapping write plan accordions DMPRoadmap#567 fixed linter issue DMPRoadmap/roadmap#issue567 fixed linter issue
jollopre
reviewed
Sep 8, 2017
| @@ -0,0 +1,47 @@ | |||
| import 'bootstrap-sass/assets/javascripts/bootstrap.min'; | |||
Contributor
There was a problem hiding this comment.
only import the bootstrap plugin that you are going to use (e.g. ... javascripts/bootstrap/collapse.js
jollopre
reviewed
Sep 8, 2017
| * </div> | ||
| * </div> | ||
| */ | ||
| export default () => { |
Contributor
There was a problem hiding this comment.
Nice collapsible abstraction!
jollopre
reviewed
Sep 8, 2017
|
|
||
| $(() => { | ||
| // Attach handlers for the expand/collapse all accordions | ||
| expandCollapseAll(); |
Contributor
There was a problem hiding this comment.
As the module expandCollapseAll always walks through any accordion-controls class, i.e. the selector is hardcoded in the module, perhaps is better if we rename this filename to something more generic since it will be used in multiple views, not only at phases/edit.
jollopre
approved these changes
Sep 8, 2017
Contributor
jollopre
left a comment
jollopre
left a comment
There was a problem hiding this comment.
Overall looks good! The minor changes can be addressed in further PRs.
johnpinto1
pushed a commit
that referenced
this pull request
Oct 6, 2021
Profile" page. Change- Added can_use_api? to the User model method can_org_admin. (Noticed, that if only can_use_api? is set, then the user sees the Admin Plans and Usage.)
johnpinto1
pushed a commit
that referenced
this pull request
Oct 13, 2021
other Org Admin privileges not set." Changes: - Replaced @user.can_org_admin? (in tests for display of API Access tab and content) with @user.can_use_api?. This insures that tabs visible in case it was failing.
briri
added a commit
that referenced
this pull request
Oct 25, 2021
…hts_not_working IssueID #629 - Fix to allow API Access tab visible on the users's "Edit
pschrey2
pushed a commit
to Belnet-be/roadmap
that referenced
this pull request
Oct 27, 2025
pschrey2
pushed a commit
to Belnet-be/roadmap
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrapped the accordions on Write Plan page #567
Note that the expand/collapse all links on the section accordion expand/collapse all of the guidances contained within the sections as well (the guidance is a nested accordion within the section accordion panel). Don't see a way around this without hacking Bootstrap a bit.
Will include tests for expandCollapseAll.js on Monday (forgot to do a
git addfrom my work machine yesterday)