Skip to content

Latest bug fixes from development and ariatiseForm.js tests#626

Merged
jollopre merged 27 commits intoDMPRoadmap:CDL-MVPfrom
CDLUC3:ariatise-tests
Sep 7, 2017
Merged

Latest bug fixes from development and ariatiseForm.js tests#626
jollopre merged 27 commits intoDMPRoadmap:CDL-MVPfrom
CDLUC3:ariatise-tests

Conversation

@briri
Copy link
Contributor

@briri briri commented Sep 6, 2017

  • Pulled in latest bug fixes from the development branch
  • Added radio buttons to ariatiseForm.js
  • Added karma-jasmine-jquery and karma-fixture
  • created fixture to test forms
  • created ariatiseFormSpec.js
  • moved existing JS tests to lib/assets/javascripts/spec

briri and others added 27 commits August 16, 2017 08:18
Pulling over latest bug fixes from DMPRoadmap
Fix for Question Format issue #603
Bug fix for MySQL issue when dropping indexes on db migrate
Pulling in bootstrapped devise pages
updated plan sharing to be case-insensitive
@briri
Copy link
Contributor Author

briri commented Sep 6, 2017

linter is failing on ariatiseFormSpec.js because it says 'fixture' is undefined. fixture is being pulled in via the karma.config though, so I'm not really sure what the best approach is to fix these linter errors. Its fine if you run npm test

@jollopre
Copy link
Contributor

jollopre commented Sep 7, 2017

I'm merging into the branch but open a new PR (e.g. #627) that fixes some problems.

@jollopre jollopre merged commit 09b8587 into DMPRoadmap:CDL-MVP Sep 7, 2017
@briri briri deleted the ariatise-tests branch September 12, 2017 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants