Fix for Question Format issue #603#604
Merged
jollopre merged 7 commits intoDMPRoadmap:developmentfrom Aug 24, 2017
Merged
Conversation
Rebase with latest bugfixes
Rebase with latest code from DCC MVP
Rebase with latest bug fixes
Pulling over latest bug fixes from DMPRoadmap
Development
…d rake task to apply fixes DMPRoadmap#603
jollopre
reviewed
Aug 24, 2017
Contributor
There was a problem hiding this comment.
Well spotted Brian, we did not seed these format types. The reason of the oddity is due to the front using the enum types for displaying the questions types whereas the admin is using string comparison. We should update everything to use enum types when bootstraping the admin part.
Contributor
|
References to my thoughts: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates the
seeds.rbfile that new installations use to seed their database tables. The file was missing thequestion_formats.formattypefield and thetoken_permissions_typetable was missing entries for 'templates' and 'statistics'