Skip to content

Bugfix for Public Export#538

Merged
briri merged 1 commit intoDMPRoadmap:CDL-MVPfrom
DigitalCurationCentre:auth_fix
Jul 24, 2017
Merged

Bugfix for Public Export#538
briri merged 1 commit intoDMPRoadmap:CDL-MVPfrom
DigitalCurationCentre:auth_fix

Conversation

@xsrust
Copy link
Contributor

@xsrust xsrust commented Jul 24, 2017

Adds authentication to public export to ensure exported plan is publicly_visible

@xsrust xsrust requested review from briri and vyruss July 24, 2017 14:24
@xsrust
Copy link
Contributor Author

xsrust commented Jul 24, 2017

Failing test is because of the implementation of this Patch:

I added an exception to allow for non-signed-in users that the plan passed to auth must be publicly_visible

The plans#index option does not pass a plan into auth, and so throws an error on the edge case of a non-signed-in user attempting to access the plans#index page.

As discussed on slack, I will update tomorrow with a more-full-fledged approach to the auth on these public pages.

@briri
Copy link
Contributor

briri commented Jul 24, 2017

yes, this is a good approach to protecting plans via that public_export path.

@briri briri merged commit 4922ad0 into DMPRoadmap:CDL-MVP Jul 24, 2017
@DigitalCurationCentre DigitalCurationCentre deleted the auth_fix branch March 12, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants