Merged
Conversation
Contributor
Author
|
Failing test is because of the implementation of this Patch: I added an exception to allow for non-signed-in users that the plan passed to auth must be publicly_visible The plans#index option does not pass a plan into auth, and so throws an error on the edge case of a non-signed-in user attempting to access the plans#index page. As discussed on slack, I will update tomorrow with a more-full-fledged approach to the auth on these public pages. |
Contributor
|
yes, this is a good approach to protecting plans via that public_export path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds authentication to public export to ensure exported plan is publicly_visible